Looks good to me. Thanks!
Xuelei
On 7/27/2020 4:03 PM, Jamil Nimeh wrote:
All taken care of.
https://cr.openjdk.java.net/~jnimeh/reviews/8247630/webrev.03/
--Jamil
On 7/27/20 1:58 PM, Xuelei Fan wrote:
Hi Jamil,
Thanks for taking the comment. The webrev looks good to me. Just a
few triv
All taken care of.
https://cr.openjdk.java.net/~jnimeh/reviews/8247630/webrev.03/
--Jamil
On 7/27/20 1:58 PM, Xuelei Fan wrote:
Hi Jamil,
Thanks for taking the comment. The webrev looks good to me. Just a
few trivial comments about the coding style. No more code review is
required to me.
Hi Jamil,
Thanks for taking the comment. The webrev looks good to me. Just a
few trivial comments about the coding style. No more code review is
required to me.
-for (NamedGroup ng : namedGroups) {
+while(ngTypes.size() < 2 && ngIter.hasNext()) {
I prefer to use for-each as it h
Hi Xuelei, I've updated the webrev based on your suggestion. It
actually made the logic a lot simpler so that was a good suggestion for
sure.
I also added a couple additional tests in ClientHelloKeyShares.java to
cover a few different namedGroup orderings.
https://cr.openjdk.java.net/~jnime
Yes, I think I could restructure this to support that approach. You're
right in that FFDHE gets the short end of the stick in the current
scheme unless it's the only type in the namedGroups property and even
then it takes the longest in terms of time. I'll restructure this and
issue a new webre
I was just wondering, could we just simplify the implementation by using
two named groups for the top two-preferred categories, without limited
to XDH and ECDHE? For example, if FFDHE is on the top 2, FFDHE will be
used as well. Normally, XDH and ECDHE will be used, but the simplifying
is a l
