Re: Review Request: 8150468: ClassCircularityError on error in security policy file

2016-05-10 Thread Sean Mullan
On 5/9/16 6:20 PM, Mandy Chung wrote: On May 6, 2016, at 11:43 AM, Sean Mullan wrote: Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8150468: http://cr.openjdk.java.net/~mullan/webrevs/8150468/webrev.00/ The fix is to record bad policy files as they are parsed and ign

Re: Review Request: 8150468: ClassCircularityError on error in security policy file

2016-05-09 Thread Mandy Chung
> On May 6, 2016, at 11:43 AM, Sean Mullan wrote: > > Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8150468: > >http://cr.openjdk.java.net/~mullan/webrevs/8150468/webrev.00/ > > The fix is to record bad policy files as they are parsed and ignore them > during any sub

Re: Review Request: 8150468: ClassCircularityError on error in security policy file

2016-05-09 Thread Xuelei Fan
Looks fine to me except a minor comment. PolicyParser.java = 1366 return i18nMessage != null ? i18nMessage : form.format(source); May be nice to set the i18nMessage if it is not set yet. Thanks, Xuelei On 5/7/2016 2:43 AM, Sean Mullan wrote: > Please review this fix for > https

Review Request: 8150468: ClassCircularityError on error in security policy file

2016-05-06 Thread Sean Mullan
Please review this fix for https://bugs.openjdk.java.net/browse/JDK-8150468: http://cr.openjdk.java.net/~mullan/webrevs/8150468/webrev.00/ The fix is to record bad policy files as they are parsed and ignore them during any subsequent permission checks. Thanks, Sean