Looks fine.
Mandy
On 08/13/2015 10:29 AM, Pete Brunet wrote:
One final update from Mandy:
- change test path to remove jdk.accessibility; only use package name
for path
- add @modules java.desktop jdk.accessibility
http://cr.openjdk.java.net/~ptbrunet/JDK-8051626/webrev.03/
Pete
On 7/16/15 8:
One final update from Mandy:
- change test path to remove jdk.accessibility; only use package name
for path
- add @modules java.desktop jdk.accessibility
http://cr.openjdk.java.net/~ptbrunet/JDK-8051626/webrev.03/
Pete
On 7/16/15 8:48 PM, Pete Brunet wrote:
> From Mandy:
> - remove unused import
>From Mandy:
- remove unused imports
- add @run main/othervm
http://cr.openjdk.java.net/~ptbrunet/JDK-8051626/webrev.02/
On 7/15/15 4:42 PM, Pete Brunet wrote:
> An update is available and mostly changes only the test case,
> Bug8151626.java. The other change is to remove jtreg.security.policy.
The fix looks fine.
On 16.07.15 0:42, Pete Brunet wrote:
An update is available and mostly changes only the test case,
Bug8151626.java. The other change is to remove jtreg.security.policy.
http://cr.openjdk.java.net/~ptbrunet/JDK-8051626/webrev.01/
Changes:
From Sean
- The jtreg @run statem
An update is available and mostly changes only the test case,
Bug8151626.java. The other change is to remove jtreg.security.policy.
http://cr.openjdk.java.net/~ptbrunet/JDK-8051626/webrev.01/
Changes:
>From Sean
- The jtreg @run statement was removed; don't specify security manager
or security
Moving the internal classes to com.sun.java.accessibility.internal is right as
com.sun.java.accessibility is a supported API. Sean is right that no need to
specify /secure=java.lang.SecurityManager.
Mandy
> On Jul 14, 2015, at 11:57 PM, Sean Mullan wrote:
>
> You don't need to add the /secur
Hi, Pete.
The fix looks fine, but you should tweak the test a little bit.
- You access the swing components on non-EDT thread.
- You should not use System.exit in the test.
- The JFrame should be disposed before the end of the test.
On 14.07.15 1:34, Pete Brunet wrote:
Please review the webre
You don't need to add the /secure option to jtreg. That's overriding
jtreg's SecurityManager and causing you to have to grant jtreg
permissions to read files in the jtreg.security.policy file. Just add
the /java.security.policy option -- this will use jtreg's
SecurityManager which is sufficient
Please review the webrev for
https://bugs.openjdk.java.net/browse/JDK-8051626
http://cr.openjdk.java.net/~ptbrunet/JDK-8051626/webrev.00/
This is so the the Java Accessibility Utilities package,
com.sun.java.accessibility.util, can be run with the security manager
active but the non-public access
