Re: Webrev request: JDK-8015081

The Subject's readObject can get called in one of two scenarios: When a Subject is deserialized and if a SecureSet is deserialized (because of the reference to the containing Subject in SecureSet). In the latter case, accessing the contents of inputPrincs before deserialization is complete caus

Re: Webrev request: JDK-8015081

Why @@ -968,14 +963,10 @@ readOnly = gf.get("readOnly", false); Set inputPrincs = (Set)gf.get("principals", null); // Rewrap the principals into a SecureSet -if (inputPrincs == null) { -throw new NullPointerException -(Resources

Re: Webrev request: JDK-8015081

Next round: This one incorporates Weijun's comments and cleans up a couple warnings in the test code. http://cr.openjdk.java.net/~weijun/8015081/webrev.05/ --Jamil On 06/06/2014 06:16 PM, Jamil Nimeh wrote: One more version of this webrev with minor comment changes: http://cr.openjdk.java.n

Re: Webrev request: JDK-8015081

Hi Max, You're probably right about collectionNullClean/throw question. When I first wrote that method I wasn't sure I'd always throw NPE as a consequent of it returning false, but it ended up working out that way. I'm already reworking a couple tests so I'll take a look at implementing thos

Re: Webrev request: JDK-8015081

Hi Jamil Sorry I've just read the webrev. If you always throw an NPE after a collectionNullClean() call, isn't it simpler to let the method throw the NPE? Also, Objects.requireNonNull(o, msg) can be used in those "if (o == null)" cases. Thanks Max On Jun 10, 2014, at 23:32, Sean Mullan wrot

Re: Webrev request: JDK-8015081

Looks good to me. --Sean On 06/06/2014 06:16 PM, Jamil Nimeh wrote: One more version of this webrev with minor comment changes: http://cr.openjdk.java.net/~ascarpino/8015081/webrev.04 Thanks, --Jamil On 06/04/2014 04:29 PM, Jamil Nimeh wrote: Hello all, This is an update to the webrev for

Re: Webrev request: JDK-8015081

One more version of this webrev with minor comment changes: http://cr.openjdk.java.net/~ascarpino/8015081/webrev.04 Thanks, --Jamil On 06/04/2014 04:29 PM, Jamil Nimeh wrote: Hello all, This is an update to the webrev for JDK-8015081 that takes into account review changes and adds a few more

Re: Webrev request: JDK-8015081

On 06/04/2014 07:29 PM, Jamil Nimeh wrote: Hello all, This is an update to the webrev for JDK-8015081 that takes into account review changes and adds a few more tests. http://cr.openjdk.java.net/~ascarpino/8015081/webrev.03 [1012]

Re: Webrev request: JDK-8015081

Hello all, This is an update to the webrev for JDK-8015081 that takes into account review changes and adds a few more tests. http://cr.openjdk.java.net/~ascarpino/8015081/webrev.03 Thanks! --Jamil On 05/27/2014 05:53 PM, Jamil Nim

Webrev request: JDK-8015081

Hello all, This bug was originally to resolve issues where Subject principal and credential Set fields containing null elements could cause NullPointerException to be thrown. It was decided to make the Subject throw NullPointerException when attempts to construct or modify Subjects will null