Re: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

2011-01-27 Thread Xuelei Fan
All suggestion are accepted. The new webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev.01/ Thanks, Xuelei On 1/27/2011 10:20 PM, Sean Mullan wrote: On 1/27/11 6:43 AM, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ * PKIXCertPathValidator [234-238]: th

Re: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

2011-01-27 Thread Sean Mullan
On 1/27/11 6:43 AM, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ * PKIXCertPathValidator [234-238]: these fields are set to null by default. I don't think you need to invoke the set methods. Yes. But in order to remind that we don't want to check the validity,

Re: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

2011-01-27 Thread Xuelei Fan
webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ On 1/27/2011 1:41 AM, Sean Mullan wrote: On 1/24/11 9:28 PM, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ Changed to use X509CertSelector to select the trust certificate. Comparing with the previous webr

Re: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

2011-01-26 Thread Sean Mullan
On 1/24/11 9:28 PM, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ Changed to use X509CertSelector to select the trust certificate. Comparing with the previous webrev, the following files are updated to use X509CertSelector: DistributionPointFetcher.java ForwardBuil

Re: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

2011-01-24 Thread Xuelei Fan
webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ Changed to use X509CertSelector to select the trust certificate. Comparing with the previous webrev, the following files are updated to use X509CertSelector: DistributionPointFetcher.java ForwardBuilder.java PKIXCertPathValidator.java Adap

Re: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

2011-01-14 Thread Sean Mullan
Hi Andrew, Did you consider using the existing X509CertSelector class to match on the authority key identifier? I actually think this should work, and it will avoid having to create the AKIDMatchState class. Take a look at the ForwardBuilder.getMatchingCACerts method towards the end, where it

Re: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

2011-01-14 Thread Xuelei Fan
On 1/15/2011 1:30 AM, Xuelei Fan wrote: > Hi Sean, > > webrev: http://cr.openjdk.java.net/~xuelei/7011497/webrev/ > Would you please review the update again. I integrate the fix for > 7011497 and 7012357 together. > > Comparing with previous webrev, the following updates are unchanged: > src/sha

Re: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

2011-01-14 Thread Xuelei Fan
Hi Sean, webrev: Would you please review the update again. I integrate the fix for 7011497 and 7012357 together. Comparing with previous webrev, the following updates are unchanged: src/share/classes/java/security/cert/CertPathValidatorException.java src/share/classes/sun/security/provider/certpa

Re: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

2011-01-13 Thread Xuelei Fan
We don't checking the SKID and AKID during searching for the trust anchor. I have filled a new CR for the issue, 7012357, Improve trust anchor searching method during cert path validation. I will have this commented out block in CPValidatorEndEntity.java. I will use this test case for CR 7012357.

Re: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

2011-01-13 Thread Xuelei Fan
On 1/14/2011 12:05 AM, Sean Mullan wrote: > On 1/13/11 6:38 AM, Xuelei Fan wrote: >> Hi Sean, >> >> Would you please review the fix for CR 7011497? >> >> http://cr.openjdk.java.net/~xuelei/7011497/webrev/ >> >> Thanks, >> Xuelei > > CPValidatorEndEntity.java: > > 307 /* coment out useles

Re: code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

2011-01-13 Thread Sean Mullan
On 1/13/11 6:38 AM, Xuelei Fan wrote: Hi Sean, Would you please review the fix for CR 7011497? http://cr.openjdk.java.net/~xuelei/7011497/webrev/ Thanks, Xuelei CPValidatorEndEntity.java: 307 /* coment out useless trust anchor 308 is = new ByteArrayInputStream(trustAnchor

code review 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm

2011-01-13 Thread Xuelei Fan
Hi Sean, Would you please review the fix for CR 7011497? http://cr.openjdk.java.net/~xuelei/7011497/webrev/ Thanks, Xuelei