Re: code review request: 6856069 PrincipalName.clone() does not invoke super.clone()

On 21/04/2010 12:24, Weijun Wang wrote: On Apr 21, 2010, at 6:53 PM, Chris Hegarty wrote: Max, Good catch to find this bug! Some comments: 1) I don't get why salt now becomes transient. I don't see that it has any effect on how the object is cloned and class is not Serializable. Reverse

Re: code review request: 6856069 PrincipalName.clone() does not invoke super.clone()

On Apr 21, 2010, at 6:53 PM, Chris Hegarty wrote: > Max, > > Good catch to find this bug! > > Some comments: > 1) I don't get why salt now becomes transient. I don't see that it has > any effect on how the object is cloned and class is not Serializable. Reversed. I just had a habit to mark a

Re: code review request: 6856069 PrincipalName.clone() does not invoke super.clone()

Max, Good catch to find this bug! Some comments: 1) I don't get why salt now becomes transient. I don't see that it has any effect on how the object is cloned and class is not Serializable. 2) You should be able to remove L128 in the new file. The cloned object will have same value for na

code review request: 6856069 PrincipalName.clone() does not invoke super.clone()

Hi Anyone can review this code change? http://cr.openjdk.java.net/~weijun/6856069/webrev.00/ Thanks Max Begin forwarded message: > *Change Request ID*: 6856069 > *Synopsis*: PrincipalName.clone() does not invoke super.clone() > > === *Description* =