Re: code review request: 6960894: Better AS-REQ creation and processing

2010-08-08 Thread Weijun Wang
Webrev updated: http://cr.openjdk.java.net/~weijun/6960894/webrev.01/ Changes made: KrbAsReqBuilder.java: 1. state and state checks 2. clear() - destroy() KrbAsReq.java: split decrypt() to decryptUsingKeys() and decryptUsingPassword() KrbKdcReq - KdcComm: The internal

Re: code review request: 6960894: Better AS-REQ creation and processing

2010-07-30 Thread Valerie (Yu-Ching) Peng
Hi, Max, KrbAsRep.java = 1) the javadoc of its decrypt method only documents the first two arguments which seems incomplete. You meant to emphasize that there two are user-provided? Maybe you can just enhance the method description. In addition, only one of the keys and password arguments is

code review request: 6960894: Better AS-REQ creation and processing

2010-06-13 Thread Weijun Wang
Hi Valerie and Andrew Please review the following webrev: http://cr.openjdk.java.net/~weijun/6960894/webrev.00 The major enhancement is KrbAsReqBuilder which generates AS-REQ, sends it, parses any response, and returns a Credentials object. The other big change is KrbKdcReq, it's no longer