Re: code review request: 6969292: make DNS lookup for realm/kdc really work

Valerie (Yu-Ching) Peng wrote: Looks fine except the following minor nit: - Why not return realm on line 1224 after a match is found? Doesn't seem necessary to continue w/ the whole for-loop. Indeed, looks like it is missing a break. -Alan.

Re: code review request: 6969292: make DNS lookup for realm/kdc really work

Updated webrev: http://cr.openjdk.java.net/~weijun/6969292/webrev.01/ Changes: checkRealm() return null instead of throwing an exception. (Thanks, Alan). Thanks Max On 07/15/2010 02:12 PM, Weijun Wang wrote: Hi Valerie 6969292: make DNS lookup for realm/kdc really work Webrev:

code review request: 6969292: make DNS lookup for realm/kdc really work

Hi Valerie 6969292: make DNS lookup for realm/kdc really work Webrev: http://cr.openjdk.java.net/~weijun/6969292/webrev.00/ We've implemented DNS lookup for realm and kdc for some time, and have made it default turned on in JDK 7. However, it's still not 100% zero-configuration, a krb5.conf