[security-dev 00969]: Re: code review request 6852744: PIT b61: PKI test suite fails because self signed certificates are being rejected

Some additional comments in the new tests describing what path building scenarios are being tested would be very useful. A few comments below. Everything else looks good. Xuelei Fan wrote: new webrev: http://cr.openjdk.java.net/~xuelei/6852744/webrev.01/ Sean Mullan wrote: Hi Andrew, Here a

[security-dev 00970]: hg: jdk7/tl/jdk: 2 new changesets

Changeset: d133d4052378 Author:ohair Date: 2009-07-08 09:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d133d4052378 6858127: Missing -DNDEBUG on Linux and Windows native code compiles Reviewed-by: tbell, dcubed ! make/common/Defs-linux.gmk ! make/common/Defs-windows.gmk

[security-dev 00971]: Re: code review request 6852744: PIT b61: PKI test suite fails because self signed certificates are being rejected

Sean Mullan wrote: Some additional comments in the new tests describing what path building scenarios are being tested would be very useful. OK, I will add some comments on the certification path structure. A few comments below. Everything else looks good. Xuelei Fan wrote: new webrev: http:

[security-dev 00972]: Re: code review request 6852744: PIT b61: PKI test suite fails because self signed certificates are being rejected

Xuelei Fan wrote: In this block of code: 858 if (principal != null && publicKey != null && 859 principal.equals(cert.getSubjectX500Principal())) { 860 if (publicKey.equals(cert.getPublicKey())) { 861 this

[security-dev 00973]: Re: code review request 6852744: PIT b61: PKI test suite fails because self signed certificates are being rejected

webrev updated, adding comments to tests: http://cr.openjdk.java.net/~xuelei/6852744/webrev.02/ Sean Mullan wrote: Xuelei Fan wrote: In this block of code: 858 if (principal != null && publicKey != null && 859 principal.equals(cert.getSubjectX500P