hg: jdk8/tl/jdk: 7076215: (jli) jdk/src/share/bin/jli_util.h should include function prototypes for str functions

2011-08-08 Thread alan . bateman
Changeset: 94934ebbb654 Author:alanb Date: 2011-08-08 13:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94934ebbb654 7076215: (jli) jdk/src/share/bin/jli_util.h should include function prototypes for str functions Reviewed-by: alanb Contributed-by: neil.richa...@ngmr.net

hg: jdk8/tl/jdk: 6380161: (reflect) Exception from newInstance() not chained to cause.

2011-08-08 Thread joe . darcy
Changeset: d4ab25d65adb Author:darcy Date: 2011-08-08 09:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4ab25d65adb 6380161: (reflect) Exception from newInstance() not chained to cause. Reviewed-by: dholmes, lancea, forax ! src/share/classes/java/lang/Class.java

hg: jdk8/tl/jdk: 2 new changesets

2011-08-08 Thread mandy . chung
Changeset: 0f1b4b3bc833 Author:mchung Date: 2011-08-08 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f1b4b3bc833 7036518: TEST_BUG: add cygwin support to test/java/nio/charset/coders/CheckSJISMappingProp.sh 7036519: TEST_BUG: add cygwin support to test/demo/zipfs/bas

Re: Code review request: 7063647, jsse/runtime, To use synchronized map in key manager

2011-08-08 Thread Brad Wetmore
Why do you need the "syncronchized (credentialsMap)" at line 344? Aren't all writes done during the constructor init? Otherwise, looks ok. Brad On 8/7/2011 8:43 PM, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net/~xuelei/7063647/webrev.00/ SunX509KeyManagerImpl should be multiple threa

Re: Code review request: 7063647, jsse/runtime, To use synchronized map in key manager

2011-08-08 Thread Xuelei Fan
On 8/9/2011 8:03 AM, Brad Wetmore wrote: > Why do you need the "syncronchized (credentialsMap)" at line 344? Aren't > all writes done during the constructor init? > The credentialsMap.entrySet() returns the reference of the backed/internal set, the iteration of the set is not thread safe. The Colle