The code changes look fine, and thanks for including the
sun/security/{tools,krb5} codes.
-Max
On 08/28/2011 06:36 PM, Xuelei Fan wrote:
Hi Weijun,
Would you please review the new update? I also include the changes in
security components.
webrev: webrev:
I reviewed the security part. In general, it looks fine. But sometimes,
from my very personal view, the exception-chain might be over used. For
example, the following code:
try {
md = MessageDigest.getInstance(SHA);
} catch (NoSuchAlgorithmException nsae) {
throw new
Your fix looks fine.
On 08/26/11 04:38 PM, Sean Mullan wrote:
Hi Vinnie,
Could you review the following webrev:
http://cr.openjdk.java.net/~mullan/webrevs/7024771/webrev.00/
A couple of notes on the webrev:
- I have removed support for DNs which use as delimiters, ex CN=foo.
This
Hi,
Sorry for the delay, was on vacation...comment inlined.
Hi, here is a webrev[1] for some cleanup that i want to integrated in
tl-repositories.
Alan Bateman had scanned the changes and gave me some good input[3]
for further discussion here:
The changes to java.util.concurrent should go
Changeset: 6d6d75421e8a
Author:weijun
Date: 2011-08-30 10:46 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d6d75421e8a
7083576: add javax/xml/crypto into jdk_security2
Reviewed-by: mullan
! test/Makefile
! test/javax/xml/crypto/dsig/SecurityManager/XMLDSigWithSecMgr.java
Hi All
7081783: jarsigner error when no $HOME/.keystore
Webrev is at --
http://cr.openjdk.java.net/~weijun/7081783/webrev.00/
Description:
jarsigner includes a certpath validation check, and shows a warning when
the check fails. The CertPathValidator object, unfortunately, is
initialized
