Re: Review request for 7020513 : Add com.sun.xml.internal to the "package.access" property in java.security

2011-08-29 Thread Florian Weimer
* Rama Pulavarthi: > Just porting the fix along with tests from Open JDK 6 workspace, > that's why I kept the old date. Does it need to be changed? This test > was added then following the convention of other tests. I will check > other tests in JDK 7 to see if it needs any update. I see that the

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-29 Thread Xuelei Fan
I reviewed the security part. In general, it looks fine. But sometimes, from my very personal view, the exception-chain might be over used. For example, the following code: try { md = MessageDigest.getInstance("SHA"); } catch (NoSuchAlgorithmException nsae) { throw new InternalErro

Re: 7024771 code review request

2011-08-29 Thread Vincent Ryan
Your fix looks fine. On 08/26/11 04:38 PM, Sean Mullan wrote: > Hi Vinnie, > > Could you review the following webrev: > > http://cr.openjdk.java.net/~mullan/webrevs/7024771/webrev.00/ > > A couple of notes on the webrev: > > - I have removed support for DNs which use <> as delimiters, ex "".

hg: jdk8/tl/jdk: 7059542: JNDI name operations should be locale independent

2011-08-29 Thread xuelei . fan
Changeset: 02c2d38f4271 Author:xuelei Date: 2011-08-29 05:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/02c2d38f4271 7059542: JNDI name operations should be locale independent Reviewed-by: weijun ! src/share/classes/com/sun/jndi/ldap/ClientId.java ! src/share/classes/com

hg: jdk8/tl/jdk: 2 new changesets

2011-08-29 Thread sean . mullan
Changeset: d1c04dac850d Author:mullan Date: 2011-08-29 12:22 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1c04dac850d 7024771: "\\<>" in attribute value part of X500Principal constructor parameter makes strange effect Reviewed-by: vinnie ! src/share/classes/sun/security/

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-29 Thread Kumar Srinivasan
Hi, Sorry for the delay, was on vacation...comment inlined. Hi, here is a webrev[1] for some cleanup that i want to integrated in tl-repositories. Alan Bateman had scanned the changes and gave me some good input[3] for further discussion here: The changes to java.util.concurrent should go t

hg: jdk8/tl/jdk: 7083576: add javax/xml/crypto into jdk_security2

2011-08-29 Thread weijun . wang
Changeset: 6d6d75421e8a Author:weijun Date: 2011-08-30 10:46 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d6d75421e8a 7083576: add javax/xml/crypto into jdk_security2 Reviewed-by: mullan ! test/Makefile ! test/javax/xml/crypto/dsig/SecurityManager/XMLDSigWithSecMgr.java

code review request: 7081783: jarsigner error when no $HOME/.keystore

2011-08-29 Thread Weijun Wang
Hi All 7081783: jarsigner error when no $HOME/.keystore Webrev is at -- http://cr.openjdk.java.net/~weijun/7081783/webrev.00/ Description: jarsigner includes a certpath validation check, and shows a warning when the check fails. The CertPathValidator object, unfortunately, is initialized

Re: [OpenJDK 2D-Dev] Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-29 Thread Sebastian Sickelmann
Am 28.08.2011 22:54, schrieb Mario Torre: Il giorno dom, 28/08/2011 alle 21.35 +0200, Sebastian Sickelmann ha scritto: Hi, here is a webrev[1] for some cleanup that i want to integrated in tl-repositories. Hi, Hi created a new webrev with your suggested changes at: http://oss-patches.24.eu/ope