code review request: 7083664: test hard code of using c:/temp but this dir might not exist

2011-08-30 Thread Weijun Wang
Hi All 7083664: test hard code of using c:/temp but this dir might not exist Webrev is at -- http://cr.openjdk.java.net/~weijun/7083664/webrev.00/ Some of our regression tests set TMP variables on different platforms, and on Windows, it's c:\temp. Unfortunately one of the test machines do

code review request: 7081411: Change more keytool -genkeypair to RSA

2011-08-30 Thread Weijun Wang
Hi All 7081411: Change more keytool -genkeypair to RSA http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7081411 Webrev at http://cr.openjdk.java.net/~weijun/7081411/webrev.01/ Because of the Solaris DSA bug described in 7041639, we keep seeing tests generating DSA key pairs failing. Therefor

hg: jdk8/tl/jdk: 2 new changesets

2011-08-30 Thread michael . x . mcmahon
Changeset: fe205518c3a7 Author:michaelm Date: 2011-08-30 14:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe205518c3a7 7084560: Crash in net.dll Reviewed-by: chegar Contributed-by: luc...@linux.vnet.ibm.com ! src/windows/native/java/net/NetworkInterface.c ! src/windows/n

Re: code review request: 7081783: jarsigner error when no $HOME/.keystore

2011-08-30 Thread Xuelei Fan
1. Do you want to add more debug info? line 1509-1511: +if (debug) { +e.printStackTrace(); +} 2. It looks a little strange to me that even if there is Runtime exception, we still do some additional work in final block. 3. I try hard to understand the code h

Re: code review request: 7083664: test hard code of using c:/temp but this dir might not exist

2011-08-30 Thread Xuelei Fan
> but I'm optimistic because in most other parts of > OpenJDK, shell script tests do not set TMP. I normally only set the variables when the test need it explicitly. So I'm also optimistic about your changes. Looks fine to me. Xuelei On 8/30/2011 3:34 PM, Weijun Wang wrote: > Hi All > > 7083664

Re: code review request: 7081411: Change more keytool -genkeypair to RSA

2011-08-30 Thread Xuelei Fan
The update, in both open and closed repositories, looks fine to me. However, the following reason cannot convince me of the necessity to make the change. > Because of the Solaris DSA bug described in 7041639, we keep seeing > tests generating DSA key pairs failing. Therefore I'm changing most > k

Re: code review request: 7083664: test hard code of using c:/temp but this dir might not exist

2011-08-30 Thread Kelly O'Hair
Looks ok to me. -kto On Aug 30, 2011, at 12:34 AM, Weijun Wang wrote: > Hi All > > 7083664: test hard code of using c:/temp but this dir might not exist > > Webrev is at -- > > http://cr.openjdk.java.net/~weijun/7083664/webrev.00/ > > Some of our regression tests set TMP variables on diffe

hg: jdk8/tl/jdk: 7084245: Update usages of InternalError to use exception chaining

2011-08-30 Thread xueming . shen
Changeset: 8a51f0e24380 Author:sherman Date: 2011-08-30 11:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a51f0e24380 7084245: Update usages of InternalError to use exception chaining Summary: to use new InternalError constructor with cause chainning Reviewed-by: alanb, k

hg: jdk8/tl/jdk: 7083664: test hard code of using c:/temp but this dir might not exist

2011-08-30 Thread weijun . wang
Changeset: f5120b47f93d Author:weijun Date: 2011-08-31 09:22 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5120b47f93d 7083664: test hard code of using c:/temp but this dir might not exist Reviewed-by: xuelei, ohair ! test/lib/security/java.policy/Ext_AllPolicy.sh ! test/s