Hello Michael,
I agree with your preference for symmetric handling of the EC point
encoding/decoding. So I've modified the decoder method in P11Key.java
to use the security provider config attribute 'useEcX963Encoding' just
like the encoder method in P11ECKeyFactory.java
The updated webrev is at:
Changeset: 5bfe2de1157b
Author:chegar
Date: 2011-10-11 12:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5bfe2de1157b
7099488: TwoStacksPlainSocketImpl should invoke super.create(stream), typo in
fix for 7098719
Reviewed-by: coffeys
! src/share/classes/java/net/AbstractP
Looks good to me.
At 08:40 AM 10/11/2011, Vincent Ryan wrote:
>Hello Michael,
>
>I agree with your preference for symmetric handling of the EC point
>encoding/decoding. So I've modified the decoder method in P11Key.java
>to use the security provider config attribute 'useEcX963Encoding' just
>like
Two things -
1) Why not just extend this to support "unsigned" long rather than just the 32
bit value - not saying it will be needed, but seems like you might as well do
this once.
2) How about cleaning up this section of code and moving it to an iterative
model:
long length = 0;
if (n < 0x
On 10/11/2011 12:50 PM, Michael StJohns wrote:
Two things -
1) Why not just extend this to support "unsigned" long rather than just the 32
bit value - not saying it will be needed, but seems like you might as well do this once.
Well, InputStream::read only supports 32-bit int, and array leng
At 04:06 PM 10/11/2011, Weijun Wang wrote:
>>2) How about cleaning up this section of code and moving it to an iterative
>>model:
>
>Yes, your codes look more correct. However, this is a regression bug and we
>need to fix it fast and with zero risk. Therefore, I choose this stupid and
>lazy co
Hi All
I've updated the webrev at
http://cr.openjdk.java.net/~weijun/7099399/webrev.01/
I would like at least 2 reviewers. It might need to go to 7u2.
The src file is identical to the last version, and I made several
changes to the test:
1. Now run in othervm. Though hasn't made any chang
Fine to me.
Xuelei
On 10/12/2011 7:32 AM, Weijun Wang wrote:
> Hi All
>
> I've updated the webrev at
>
> http://cr.openjdk.java.net/~weijun/7099399/webrev.01/
>
> I would like at least 2 reviewers. It might need to go to 7u2.
>
> The src file is identical to the last version, and I made sev
Changeset: dd55467dd1f2
Author:ngmr
Date: 2011-10-10 14:50 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd55467dd1f2
7099119: Remove unused dlinfo local variable in launcher code
Reviewed-by: ohair, chegar, ngmr
Contributed-by: Steve Poole
! src/solaris/bin/java_md.c
Cha
