hg: jdk8/tl/jdk: 2 new changesets

2012-02-13 Thread vincent . x . ryan
Changeset: 3554f175341a Author:vinnie Date: 2012-02-13 14:26 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3554f175341a 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done Reviewed-by: xuelei, wetmore ! src/share/classes

Code review request: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc

2012-02-13 Thread Vincent Ryan
Please review the following change: http://cr.openjdk.java.net/~vinnie/7142888/webrev.00/ for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142888 Some implementations of the SHA512withECDSA signing algorithm require that the signing/validation key is at least 512 bits. Thanks.

Re: Code review request: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc

2012-02-13 Thread Xuelei Fan
On Feb 14, 2012, at 12:47 AM, Vincent Ryan wrote: > Please review the following change: > http://cr.openjdk.java.net/~vinnie/7142888/webrev.00/ > > for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142888 > > Some implementations of the SHA512withECDSA signing algorithm require > that th

hg: jdk8/tl/jaxws: 7140918: Remove dependency on apt and com.sun.mirror API

2012-02-13 Thread alan . bateman
Changeset: 6a8f54fb5f15 Author:alanb Date: 2012-02-05 12:07 + URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6a8f54fb5f15 7140918: Remove dependency on apt and com.sun.mirror API Reviewed-by: darcy Contributed-by: miroslav@oracle.com, martin.gre...@oracle.com ! build-def

Re: Code review request: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc

2012-02-13 Thread Vincent Ryan
On 02/13/12 05:04 PM, Xuelei Fan wrote: > On Feb 14, 2012, at 12:47 AM, Vincent Ryan wrote: > >> Please review the following change: >> http://cr.openjdk.java.net/~vinnie/7142888/webrev.00/ >> >> for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7142888 >> >> Some implementations of the SHA

Re: Code review request: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc

2012-02-13 Thread Michael StJohns
At 12:24 PM 2/13/2012, Vincent Ryan wrote: >On 02/13/12 05:04 PM, Xuelei Fan wrote: >> On Feb 14, 2012, at 12:47 AM, Vincent Ryan wrote: >> >>> Please review the following change: >>> http://cr.openjdk.java.net/~vinnie/7142888/webrev.00/ >>> >>> for http://bugs.sun.com/bugdatabase/view_bug.do?bu

Re: Code review request: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc

2012-02-13 Thread Vincent Ryan
Hello Michael, Thanks for providing those details. This specific fix is a workaround for a test failure using SunPKCS11-Solaris provider on Sparc. I'll file a separate bug to correct the issue of matching hash length to key length. On 02/13/12 05:40 PM, Michael StJohns wrote: > At 12:24 PM 2/1

Code Review Request: 7024604 OID.1 causes IAE in X500Principal constructor

2012-02-13 Thread Sean Mullan
Hi Vinnie, Could you please review my fix for 7024604? http://cr.openjdk.java.net/~mullan/webrevs/7024604/webrev.00/ A CCC has been approved and I will post the final revision after you have reviewed the code. Thanks, Sean

Re: Code review request

2012-02-13 Thread Valerie (Yu-Ching) Peng
Looks good to me. Thanks, Valerie On 02/09/12 22:43, Brad Wetmore wrote: Two line code fix, but an important couple of lines. :) The underlying cipher still had buffered data when using Direct ByteBuffers. This changes makes sure that data is read out. 7142509: Cipher.doFinal(ByteBuf

hg: jdk8/tl/langtools: 7142672: Problems with the value passed to the 'classes' param of JavaCompiler.CompilationTask.getTask(...)

2012-02-13 Thread jim . holmlund
Changeset: 237198ef45f5 Author:jjh Date: 2012-02-13 16:01 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/237198ef45f5 7142672: Problems with the value passed to the 'classes' param of JavaCompiler.CompilationTask.getTask(...) Reviewed-by: jjg ! src/share/classes/com/s

Re: Code review request: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc

2012-02-13 Thread Xuelei Fan
The fix looks fine to me. Xuelei On 2/14/2012 2:49 AM, Vincent Ryan wrote: Hello Michael, Thanks for providing those details. This specific fix is a workaround for a test failure using SunPKCS11-Solaris provider on Sparc. I'll file a separate bug to correct the issue of matching hash length t