hg: jdk8/tl/jdk: 7140868: TEST_BUG: jcmd tests need to use -XX:+UsePerfData

2012-02-15 Thread frederic . parain
Changeset: 13aef38438d8 Author:fparain Date: 2012-02-14 07:28 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13aef38438d8 7140868: TEST_BUG: jcmd tests need to use -XX:+UsePerfData Reviewed-by: fparain, dholmes ! test/sun/tools/jcmd/jcmd-Defaults.sh ! test/sun/tools/jcmd/jcm

hg: jdk8/tl/jdk: 2 new changesets

2012-02-15 Thread sean . mullan
Changeset: 0720542d6c1e Author:mullan Date: 2012-02-15 07:45 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0720542d6c1e 7024604: OID.1 causes IAE in X500Principal constructor Reviewed-by: vinnie ! src/share/classes/javax/security/auth/x500/X500Principal.java ! src/share/cla

Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom

2012-02-15 Thread Xuelei Fan
webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev/ To use only one instance of SecureRandom for dummy/useless CipherBox initialization. Thanks, Xuelei

Re: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom

2012-02-15 Thread Chris Hegarty
Just out of curiosity, why is secureRandom defined in the outer class rather than privately in BulkCipher?? -Chris. On 15/02/2012 14:21, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev/ To use only one instance of SecureRandom for dummy/useless CipherBox initializa

Re: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom

2012-02-15 Thread Xuelei Fan
On 2/15/2012 11:06 PM, Chris Hegarty wrote: Just out of curiosity, why is secureRandom defined in the outer class rather than privately in BulkCipher?? Good point. It should be in BulkCipher. Thanks, Xuelei -Chris. On 15/02/2012 14:21, Xuelei Fan wrote: webrev: http://cr.openjdk.java.net/~

Re: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom

2012-02-15 Thread Xuelei Fan
I believe I have replied the mail. But cannot find the mail in the mail system. It's weird. New webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev.01/. Moved secureRandom into BulkCipher block. Thanks, Xuelei On 2/15/2012 11:06 PM, Chris Hegarty wrote: Just out of curiosity, why is s

Re: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom

2012-02-15 Thread Chris Hegarty
Looks fine to me, but I'm sure someone closer to the security area may also want to review. -Chris. On 15/02/2012 15:45, Xuelei Fan wrote: I believe I have replied the mail. But cannot find the mail in the mail system. It's weird. New webrev: http://cr.openjdk.java.net/~xuelei/7145837/webrev.

hg: jdk8/tl/jdk: 7144833: sun/tools/jcmd/jcmd-Defaults.sh failing intermittently

2012-02-15 Thread frederic . parain
Changeset: 59884f656b7d Author:fparain Date: 2012-02-15 09:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59884f656b7d 7144833: sun/tools/jcmd/jcmd-Defaults.sh failing intermittently Reviewed-by: alanb ! test/ProblemList.txt ! test/sun/tools/jcmd/jcmd_Output1.awk

hg: jdk8/tl/jaxws: 7145910: Remove dependency on apt and com.sun.mirror API (breaks boot cycle builds)

2012-02-15 Thread alan . bateman
Changeset: b962e9c3eba2 Author:alanb Date: 2012-02-15 17:32 + URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b962e9c3eba2 7145910: Remove dependency on apt and com.sun.mirror API (breaks boot cycle builds) Reviewed-by: ohair ! jaxws.properties

hg: jdk8/tl/jdk: 7145925: Removing remote access to diagnostic commands in the HotSpotDiagnosticMBean

2012-02-15 Thread frederic . parain
Changeset: 20d39a0e6fdc Author:fparain Date: 2012-02-15 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/20d39a0e6fdc 7145925: Removing remote access to diagnostic commands in the HotSpotDiagnosticMBean Reviewed-by: acorn, mchung, phh ! make/java/management/mapfile-vers

Re: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom

2012-02-15 Thread Brad Wetmore
Looks ok to me too, but it seems a shame to keep this SecureRandom instance for a single test (AES_256) during cipher initialization. Once the condition is test, and the result is added to the cache, the SecureRandom instance is never used again. Brad On 2/15/2012 8:03 AM, Chris Hegarty wr

Re: Code review request, CR 7145837, jsse/runtime, a little performance improvement on the usage of SecureRandom

2012-02-15 Thread Xuelei Fan
Thanks for the review. On Feb 16, 2012, at 7:28 AM, Brad Wetmore wrote: > Looks ok to me too, but it seems a shame to keep this SecureRandom instance > for a single test (AES_256) during cipher initialization. Once the condition > is test, and the result is added to the cache, the SecureRando

hg: jdk8/tl/jdk: 7145837: a little performance improvement on the usage of SecureRandom

2012-02-15 Thread xuelei . fan
Changeset: 45804d661008 Author:xuelei Date: 2012-02-15 23:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/45804d661008 7145837: a little performance improvement on the usage of SecureRandom Reviewed-by: chegar, wetmore ! src/share/classes/sun/security/ssl/CipherSuite.java