Code review request: 7152582 PKCS11 tests should use the NSS libraries available in the OS

2012-03-09 Thread Vincent Ryan
Sean, Please review the fix for: 7152582 PKCS11 tests should use the NSS libraries available in the OS Webrev: http://cr.openjdk.java.net/~vinnie/7152582/webrev.00/ Thanks.

hg: jdk8/tl/langtools: 7151802: compiler update caused sqe test failed

2012-03-09 Thread maurizio . cimadamore
Changeset: 97bec6ab1227 Author:mcimadamore Date: 2012-03-09 17:10 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/97bec6ab1227 7151802: compiler update caused sqe test failed Summary: Fix regression caused by 7144506 Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun

Re: Code review request: 7152582 PKCS11 tests should use the NSS libraries available in the OS

2012-03-09 Thread Sean Mullan
Looks ok, except I was a bit puzzled why this line was removed in PKCS11Test.java, can you explain: osMap.put("Windows-x86-32", "windows-i586"); --Sean On 03/09/2012 10:17 AM, Vincent Ryan wrote: Sean, Please review the fix for: 7152582 PKCS11 tests should use the NSS libraries availab

Re: Code Review Request for 7146728 and 7130959

2012-03-09 Thread Valerie (Yu-Ching) Peng
Ok, more comments/changes added as suggested. Webrev updated at: http://cr.openjdk.java.net/~valeriep/7146728/webrev.02/ Thanks, Valerie On 03/08/12 17:15, Brad Wetmore wrote: >> DHKeyAgreement: >> === > I added more comments to both code blocks to explain what's going on. A cou