hg: jdk8/tl/jdk: 7152798: TEST_BUG: sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java does not compile

2012-03-19 Thread staffan . larsen
Changeset: 3b50a4971a1a Author:sla Date: 2012-03-19 14:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b50a4971a1a 7152798: TEST_BUG: sun/management/HotspotClassLoadingMBean/GetClassLoadingTime.java does not compile Summary: Make sure the test is compiled, run and finds

Code review request, 7155051 jndi/dns, DNS provider may return incorrect results

2012-03-19 Thread Xuelei Fan
Hi, Please review the fix: webrev: http://cr.openjdk.java.net/~xuelei/7155051/webrev.00/ Cause of the issue: The DNS provider attempts to check the XID of the response to make sure the response received from the server matches the requested XID. If the response's XID does not match, the DNS pro

Re: Code Review Request for 7146728 and 7130959

2012-03-19 Thread Brad Wetmore
Minor comment: // Array too short, pad it w/ leading 0s including the sign bit Can you pull off: "including the sign bit" Looks good to me otherwise. Brad On 3/16/2012 1:42 PM, Valerie (Yu-Ching) Peng wrote: Brad, As I was preparing the files for putting back, I noticed some now-redund

Re: Code review request, 7155051 jndi/dns, DNS provider may return incorrect results

2012-03-19 Thread Chris Hegarty
On 19/03/12 18:47, Xuelei Fan wrote: Hi, Please review the fix: webrev: http://cr.openjdk.java.net/~xuelei/7155051/webrev.00/ Wow, strange this wasn't seen before. The change looks fine to me. -Chris. Cause of the issue: The DNS provider attempts to check the XID of the response to make