The webrev is at
http://cr.openjdk.java.net/~weijun/7158329/webrev.00/
There are two places where the content (getDefaultCreds) of a cache
might be null, one with a specified ccache file name, one default. In
order to check for both, a KRB5CCNAME environment variable is needed.
Therefore th
Changeset: 92de69b24416
Author:jgish
Date: 2012-04-05 13:57 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92de69b24416
7133806: Typo in Files.newByteChannel javadoc
Reviewed-by: chegar
! src/share/classes/java/nio/file/Files.java
Max,
If it were me writing the test, I'd avoid using a shell script and would
write Java code using ProcessBuilder to set an env-var and then realunch
the test via new File(new File(System.getProperty("java.home"), "bin"),
"java");
This Java code could even be co-located in the EmptyCC.java
Webrev updated:
http://cr.openjdk.java.net/~weijun/7158329/webrev.01
No change to src.
*Jon*: Is this the correct style to use ProcessBuilder to launch a test?
I guess there is no need to go othervm?
*Valerie*: Can you take a review on this?
Thanks
Max
On 04/06/2012 02:29 AM, Jonathan Gi
Max,
You definitely don't need /othervm, since the test itself is talking
care to run the subprocess.
Generally, I like to use pb.redirectErrorStream(true) to merge stdout
and stderr, so that you are guaranteed that neither will fill up the
buffer and block for want of a reader.
There's lo
On 04/06/2012 11:31 AM, Jonathan Gibbons wrote:
Max,
You definitely don't need /othervm, since the test itself is talking
care to run the subprocess.
Generally, I like to use pb.redirectErrorStream(true) to merge stdout
and stderr, so that you are guaranteed that neither will fill up the
buff
On 04/06/2012 11:31 AM, Jonathan Gibbons wrote:
Max,
You definitely don't need /othervm, since the test itself is talking
care to run the subprocess.
Generally, I like to use pb.redirectErrorStream(true) to merge stdout
and stderr, so that you are guaranteed that neither will fill up the
buff
