hg: jdk8/tl/jdk: 7166055: Javadoc for WeakHashMap contains misleading advice

2012-06-04 Thread littlee
Changeset: 237e27c7ddc3 Author:littlee Date: 2012-06-04 16:30 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/237e27c7ddc3 7166055: Javadoc for WeakHashMap contains misleading advice Reviewed-by: dholmes, mduigou ! src/share/classes/java/util/WeakHashMap.java

hg: jdk8/tl/jdk: 7173036: test/com/sun/jdi/ConnectedVMs.java does not run as expected

2012-06-04 Thread weijun . wang
Changeset: a5bb0343f135 Author:weijun Date: 2012-06-04 18:06 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5bb0343f135 7173036: test/com/sun/jdi/ConnectedVMs.java does not run as expected Reviewed-by: alanb ! test/com/sun/jdi/ConnectedVMs.java

Re: hg: jdk8/tl/jdk: 6924259: Remove offset and count fields from java.lang.String

2012-06-04 Thread Peter Levart
On Thursday, May 31, 2012 03:22:35 AM mike.dui...@oracle.com wrote: > Changeset: 2c773daa825d > Author:mduigou > Date: 2012-05-17 10:06 -0700 > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c773daa825d > > 6924259: Remove offset and count fields from java.lang.String > Summary: R

Re: Code review request for JEP-121

2012-06-04 Thread Valerie (Yu-Ching) Peng
Vinnie, I am still reviewing the changes. Just some quick comments and questions: Your current changes have both PBES1 and PBES2 impl inside the PBECipherCore.java but yet there is another new classPBES2Core.java which seems to just delegate the calls to the internal PBECipherCore object. Hav

Re: Code review request for 7172149 ArrayIndexOutOfBoundsException from Signature.verify

2012-06-04 Thread Brad Wetmore
Looks good to me, however, we are still checking on the copyright notice in the test. I think what you have is ok, but want to run it by one other person. Hope to hear back soon. The bug presents an interesting and obvious problem when you think of it. Wonder how many things we have like th

hg: jdk8/tl/jdk: 7173044: MemoryMonitor hangs if getMax method in MemoryUsage object returns -1

2012-06-04 Thread littlee
Changeset: 4573662cb28c Author:zhouyx Date: 2012-06-05 10:16 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4573662cb28c 7173044: MemoryMonitor hangs if getMax method in MemoryUsage object returns -1 Reviewed-by: dholmes, sspitsyn ! src/share/demo/management/MemoryMonitor/Me

Re: Code review request for 7172149 ArrayIndexOutOfBoundsException from Signature.verify

2012-06-04 Thread Xuelei Fan
Hi Jonathan, The fix, including the copyright notice, looks good to us. Are you a committer of OpenJDK? Otherwise, I would like to help to integrate the fix into OpenJDK. Thanks, Xuelei On 6/5/2012 8:52 AM, Brad Wetmore wrote: > Looks good to me, however, we are still checking on the copyright n