Code review request, CR 7174244, NPE in Krb5ProxyImpl.getServerKeys()

Hi Weijun, Would you please review the fix for CR 7174244. http://cr.openjdk.java.net./~xuelei/7174244/webrev.00/ There are mainly two updates in the fix. One is to have Krb5ProxyImpl.getServerKeys() to check null return value of Krb5Util.getServiceCreds(). The other one is to have cipher su

Re: Code review request, CR 7174244, NPE in Krb5ProxyImpl.getServerKeys()

Hi Xuelei I don't quite understand the bug report. Certainly it's good to prevent that NPE, but why must the cipher suites be ordered? It seems it's not ordered before the new HashMap. Is this a regression or an RFE? You'd better add some explanation in the bug report. Thanks Max On 06/06/2

Re: Code review request, CR 7174244, NPE in Krb5ProxyImpl.getServerKeys()

On 6/6/2012 9:11 PM, Weijun Wang wrote: > Hi Xuelei > > I don't quite understand the bug report. Certainly it's good to prevent > that NPE, but why must the cipher suites be ordered? It seems it's not > ordered before the new HashMap. No, it was not ordered because of a regression. > Is this a re

Re: Code review request, CR 7174244, NPE in Krb5ProxyImpl.getServerKeys()

Then the fix is fine. Please add the CR that causes this regression to the see also field. -Max On 06/06/2012 09:22 PM, Xuelei Fan wrote: On 6/6/2012 9:11 PM, Weijun Wang wrote: Hi Xuelei I don't quite understand the bug report. Certainly it's good to prevent that NPE, but why must the ciphe

hg: jdk8/tl/jdk: 7172826: (se) Selector based on the Solaris event port mechanism

Changeset: 119c9a306a3d Author:alanb Date: 2012-06-06 17:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/119c9a306a3d 7172826: (se) Selector based on the Solaris event port mechanism Reviewed-by: coffeys, chegar ! make/java/nio/Makefile ! make/java/nio/mapfile-linux ! make

hg: jdk8/tl/jdk: 7173645: (props) System.getProperty("os.name") should return "Windows Server 2012" for Windows Server 2012

Changeset: af313ded4ffb Author:khazra Date: 2012-06-06 11:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af313ded4ffb 7173645: (props) System.getProperty("os.name") should return "Windows Server 2012" for Windows Server 2012 Summary: Enable Windows Server 2012 to be recog

Adding an adaptive hashing algorithm to the JDK

Hi I'd like to see a bcrypt implementation added to the JDK and would like to write the code required too. Does this sound like a feasible task, are there any reasons it would be dead in the water before I've even opened an editor? Thanks Rich

Avoid PrincipalName with realm == null

Hi Valerie The krb5 PrincipalName class has a realm field and the class says If null, means the default realm Ideally this means if the realm of a name is null then this field can be null. Otherwise, it must be filled when created. In fact, inside our codes, the field is often filled (usi

Re: Avoid PrincipalName with realm == null

Ideally this means if the realm of a name is null then this field can be null. Otherwise, it must be filled when created. Should be "if the realm of a name is the default realm".

hg: jdk8/tl/jdk: 7174244: NPE in Krb5ProxyImpl.getServerKeys()

Changeset: f8e72d7ff37d Author:xuelei Date: 2012-06-06 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8e72d7ff37d 7174244: NPE in Krb5ProxyImpl.getServerKeys() Reviewed-by: weijun ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/securit

hg: jdk8/tl/jdk: 7172149: ArrayIndexOutOfBoundsException from Signature.verify

Changeset: 713b10821c3d Author:xuelei Date: 2012-06-06 18:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/713b10821c3d 7172149: ArrayIndexOutOfBoundsException from Signature.verify Summary: take care of integer addition overflow Reviewed-by: xuelei, wetmore Contributed-by:

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 181175887d24 Author:jonas Date: 2012-06-06 13:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/181175887d24 7174861: all/OPT jdk build on Solaris with FDS enabled sets wrong options Summary: Use CFLAGS_COMMON instead of CC_OPT and CXXFLAGS_COMMON instead of CXX_O