On 7/2/12 11:14 PM, Weijun Wang wrote:
> One minor thing:
>
> Line 25 should be empty, this starts another paragraph on providers.
I'm not sure I understand the comment as it is empty already.
--Sean
>
> Thanks
> Max
>
> On 07/03/2012 01:34 AM, Sean Mullan wrote:
>> Yep, looks good.
>>
>> On
The current line 25 has a "#" and I prefer it to be a real empty line.
-Max
On 07/03/2012 07:49 PM, Sean Mullan wrote:
On 7/2/12 11:14 PM, Weijun Wang wrote:
One minor thing:
Line 25 should be empty, this starts another paragraph on providers.
I'm not sure I understand the comment as it is
On 7/3/12 7:57 AM, Weijun Wang wrote:
> The current line 25 has a "#" and I prefer it to be a real empty line.
Ok, I understand now. Yes, I agree that would be a good change.
--Sean
>
> -Max
>
> On 07/03/2012 07:49 PM, Sean Mullan wrote:
>> On 7/2/12 11:14 PM, Weijun Wang wrote:
>>> One minor
Thanks, Max and Sean.
Now with the empty line: http://cr.openjdk.java.net/~juh/7133344/webrev.02/
Jason
On 07/03/2012 05:00 AM, Sean Mullan wrote:
On 7/3/12 7:57 AM, Weijun Wang wrote:
The current line 25 has a "#" and I prefer it to be a real empty line.
Ok, I understand now. Yes, I agree
Changeset: d375ea39ce9c
Author:mullan
Date: 2012-07-03 14:56 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d375ea39ce9c
7133344: Document the java.security.properties system property feature in the
java.security file
Reviewed-by: hawtin, mullan, weijun
Contributed-by: jason
Looks good. I'll push the changeset for you.
--Sean
On 7/3/12 2:28 PM, Jason Uh wrote:
> Thanks, Max and Sean.
>
> Now with the empty line: http://cr.openjdk.java.net/~juh/7133344/webrev.02/
>
> Jason
>
> On 07/03/2012 05:00 AM, Sean Mullan wrote:
>> On 7/3/12 7:57 AM, Weijun Wang wrote:
>>> T
Changeset: 4ca599497172
Author:katleman
Date: 2012-06-28 09:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4ca599497172
Added tag jdk8-b45 for changeset e111e4587cca
! .hgtags
Changeset: 30141e598d72
Author:katleman
Date: 2012-06-28 09:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/30141e598d72
Added tag jdk8-b45 for changeset 747dad9e9d37
! .hgtags
Changeset: 666efea2df67
Author:lana
Date: 2012-07-03 18:23 -0700
URL: http://h
Changeset: 27fa766a2298
Author:katleman
Date: 2012-06-28 09:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/27fa766a2298
Added tag jdk8-b45 for changeset 633f2378c904
! .hgtags
Changeset: 300f45e99064
Author:katleman
Date: 2012-06-28 09:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/300f45e99064
Added tag jdk8-b45 for changeset 57476f66e13c
! .hgtags
Changeset: 9cb8be5e6119
Author:lana
Date: 2012-07-03 18:24 -0700
URL: http://hg
Changeset: ae368a83c240
Author:katleman
Date: 2012-06-28 09:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/ae368a83c240
Added tag jdk8-b45 for changeset e80ac58b5ba9
! .hgtags
Changeset: 8d2ed9d58453
Author:katleman
Date: 2012-06-28 09:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d2ed9d58453
Added tag jdk8-b45 for changeset b92353a01aa0
! .hgtags
Changeset: 8ccbd5aabeab
Author:lana
Date: 2012-07-03 18:24 -0700
URL: http://hg.
Changeset: a8b9798c1d45
Author:katleman
Date: 2012-06-28 09:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a8b9798c1d45
Added tag jdk8-b45 for changeset 9d5f20961bc5
! .hgtags
Changeset: 1c280e5b8d31
Author:amurillo
Date: 2012-06-15 14:17 -0700
URL: ht
Changeset: 3ae91286f313
Author:xuelei
Date: 2012-07-03 20:29 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3ae91286f313
7180038: regression test failure, SSLEngineBadBufferArrayAccess.java
Reviewed-by: weijun
!
test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineIm
14 matches
Mail list logo