Re: Code review request for JEP-121

2012-10-11 Thread Vincent Ryan
Thanks for this latest review. Comments below. On 11/10/2012 04:16, Valerie (Yu-Ching) Peng wrote: Hi, Vinnie, Here are my comments on the latest webrev 04. => looks fine. => Well, the fields contains the new cipherParam field needed for PBES2 cipher, but the encoding is still for the

hg: jdk8/tl/jdk: 7152183: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently [sol]

2012-10-11 Thread rob . mckenna
Changeset: 7c2f5e52863c Author:robm Date: 2012-10-11 18:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c2f5e52863c 7152183: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently [sol] Reviewed-by: alanb, martin, dholmes ! test/java/lang/ProcessBuilder/Bas