Re: Code review request: 7197652: Impossible to run any signed JNLP applications or applets, OCSP off by default

2012-10-16 Thread Vincent Ryan
We used to have automated tests that accessed live OCSP responders but results were often unreliable because of intermittent network and proxy issues. I am developing an automated test that uses a cached OCSP response which will be more robust. On 16 Oct 2012, at 11:52, Xerxes Rånby wrote: > 2

configuration files in ${java.home}/lib/security

2012-10-16 Thread Alan Bateman
As part of preparing for modules in the future [1], we need to look at configuration (and other) files in the JDK and see whether such files could eventually move to module-private locations. There are several files in ${java.home}/lib/security and I'm trying to get a feel for how common it is

Re: configuration files in ${java.home}/lib/security

2012-10-16 Thread Sean Mullan
On 10/16/2012 09:55 AM, Alan Bateman wrote: As part of preparing for modules in the future [1], we need to look at configuration (and other) files in the JDK and see whether such files could eventually move to module-private locations. There are several files in ${java.home}/lib/security and I'm

hg: jdk8/tl/jdk: 8000245: SimpleDateFormat.format(date, StringBuffer, FieldPosition) doesn't work as expected with custom extensions; ...

2012-10-16 Thread naoto . sato
Changeset: 32452042b781 Author:naoto Date: 2012-10-16 10:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/32452042b781 8000245: SimpleDateFormat.format(date, StringBuffer, FieldPosition) doesn't work as expected with custom extensions 8000273: java.util.Locale.getDisplayVar

Re: Code review request, JEP 114, 7068321 Support TLS Server Name Indication (SNI) Extension in JSSE Server

2012-10-16 Thread Brad Wetmore
BTW, both 7068321 and 8000954 are in Open, should be "In Progress". On 10/15/2012 6:27 PM, Xuelei Fan wrote: On 10/16/2012 7:12 AM, Brad Wetmore wrote: Looks good. The main update is to add "final" keyword to the new methods in SSLParamaters. I prefer to use the final because I don't see a r

Re: Code review request: 7197652: Impossible to run any signed JNLP applications or applets, OCSP off by default

2012-10-16 Thread Xerxes Rånby
2012-10-01 04:30, Vincent Ryan wrote: > Please review these changes for JDK 7 to correct the trust decision when > examining the signer certificate of an OCSP response. When matching two > certificates the key identifiers should only be checked if present in both. > > http://cr.openjdk.java.net/~

hg: jdk8/tl/jdk: 7198073: (prefs) user prefs not saved [macosx]

2012-10-16 Thread kurchi . subhra . hazra
Changeset: 3a6b76a468bd Author:khazra Date: 2012-10-16 15:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a6b76a468bd 7198073: (prefs) user prefs not saved [macosx] Summary: Using class member field to get node instead of argument Reviewed-by: alanb ! src/macosx/classes/j

Re: Code review request, JEP 114, 7068321 Support TLS Server Name Indication (SNI) Extension in JSSE Server

2012-10-16 Thread Xuelei Fan
On 10/17/2012 4:57 AM, Brad Wetmore wrote: > You could push both together and put everything in just one changeset, > but of course up to you. > Good. Please review the CCC request, I will fast-track the request. > I don't think there's anything else for me to do, let me know if you're > waiting

Re: Code review request, JEP 114, 7068321 Support TLS Server Name Indication (SNI) Extension in JSSE Server

2012-10-16 Thread Xuelei Fan
On 10/17/2012 9:30 AM, Xuelei Fan wrote: > On 10/17/2012 4:57 AM, Brad Wetmore wrote: >> You could push both together and put everything in just one changeset, >> but of course up to you. >> > Good. > > Please review the CCC request, I will fast-track the request. > http://ccc.us.oracle.com/80009

Re: Code review request, JEP 114, 7068321 Support TLS Server Name Indication (SNI) Extension in JSSE Server

2012-10-16 Thread Brad Wetmore
Approved. Brad On 10/16/2012 6:30 PM, Xuelei Fan wrote: On 10/17/2012 9:30 AM, Xuelei Fan wrote: On 10/17/2012 4:57 AM, Brad Wetmore wrote: You could push both together and put everything in just one changeset, but of course up to you. Good. Please review the CCC request, I will fast-trac

hg: jdk8/tl/langtools: 8000673: remove dead code from HtmlWriter and subtypes

2012-10-16 Thread jonathan . gibbons
Changeset: 2013982bee34 Author:jjg Date: 2012-10-16 21:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2013982bee34 8000673: remove dead code from HtmlWriter and subtypes Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.

Re: configuration files in ${java.home}/lib/security

2012-10-16 Thread David Schlosnagle
In my experience, altering the enabled security providers and precedence have been the primary reason for modifications and overrides of the ${JAVA_HOME}/lib/security/java.security file. Typically this has been in the context of removing unnecessary providers, as well as restricting algorithms and

Re: Request for comment: Supporting password expiration alert in JAAS

2012-10-16 Thread Weijun Wang
Ping again. On 08/17/2012 06:18 PM, Weijun Wang wrote: Hi All I am working with an OpenJDK contributor (Steve Beaty) recently on this feature. We often see messages like "Your password will expire in 5 days. Please update ASAP" when we login to a system, and we are seeing if we could also supp