Re: Transitioning the default keystore format to PKCS#12

2012-11-02 Thread Vincent Ryan
On 1 Nov 2012, at 23:55, Weijun Wang wrote: > > > 在 Nov 1, 2012，10:49 PM，Bruce Rich 写道： > >> Max, >> >> There is already substantial usage of JCEKS to store secret keys. And that >> has been operational since Java 5. >> So I'm not sure what question you are asking. One might have aske

hg: jdk8/tl/jdk: 8001209: Evaluate findbugs reprot for java.text.ChoiceFormat

2012-11-02 Thread yuka . kamiya
Changeset: 98a47dc23296 Author:peytoia Date: 2012-11-02 23:17 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98a47dc23296 8001209: Evaluate findbugs reprot for java.text.ChoiceFormat Reviewed-by: okutsu ! src/share/classes/java/text/ChoiceFormat.java + test/java/text/Format/

Re: Transitioning the default keystore format to PKCS#12

2012-11-02 Thread Vincent Ryan
On 2 Nov 2012, at 04:14, Michael StJohns wrote: > At 02:26 PM 11/1/2012, Vincent Ryan wrote: > >> On 1 Nov 2012, at 17:50, Michael StJohns wrote: >> >>> At 12:55 PM 10/31/2012, Vincent Ryan wrote: >>> Before considering migrating the platform default keystore format to PKCS12 its ke

Re: Code review request for JEP-121

2012-11-02 Thread Vincent Ryan
Thanks for all your comments so far. Here's my latest webrev: http://cr.openjdk.java.net/~vinnie/6383200/webrev.05/ There are 2 TBD's remaining that involve code re-factoring (in PKCS12PBECipherCore & PBES2Core) which I'd like to handle separately, later. Thanks. On 27 Oct 2012, at 00:18, Va

[8] Code Review Request for CR 7171570 - JEP 124 Potential API Changes

2012-11-02 Thread Sean Mullan
Please review the following webrev consisting of a few minor API updates to JEP 124 [1] that were leftover from the code review. bug : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171570 webrev: http://cr.openjdk.java.net/~mullan/webrevs/7171570/webrev.00/ Thanks, Sean [1] http://openjd

hg: jdk8/tl/langtools: 8000483: cryptic error message when source file contains hash

2012-11-02 Thread jonathan . gibbons
Changeset: 75c936d14c6a Author:vromero Date: 2012-11-01 12:47 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/75c936d14c6a 8000483: cryptic error message when source file contains hash Summary: cryptic error message when source file contains hash Reviewed-by: jjg, mcimad

hg: jdk8/tl/langtools: 7169362: JDK8: Write compiler tests for repeating annotations for JDK8

2012-11-02 Thread jonathan . gibbons
Changeset: bf76f4190ef8 Author:jjg Date: 2012-11-02 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bf76f4190ef8 7169362: JDK8: Write compiler tests for repeating annotations for JDK8 Reviewed-by: darcy, jjg Contributed-by: sonali.g...@oracle.com + test/tools/java

Code Review Request for 6996769: support AEAD ciphers

2012-11-02 Thread Valerie (Yu-Ching) Peng
Brad or Max, Can either of you review my changes for the following RFE? 6996769: support AEAD ciphers This is the JCE part of changes for the EFP "Support AEAD CipherSuites". The webrev is at: http://cr.openjdk.java.net/~valeriep/6996769/webrev.00/ I included IBM copyright in files where some

Re: [8] Code Review Request for CR 7171570 - JEP 124 Potential API Changes

2012-11-02 Thread Xuelei Fan
Looks fine to me. Xuelei On 11/3/2012 2:49 AM, Sean Mullan wrote: > Please review the following webrev consisting of a few minor API updates > to JEP 124 [1] that were leftover from the code review. > > bug : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171570 > webrev: http://cr.openjdk.

hg: jdk8/tl/langtools: 2 new changesets

2012-11-02 Thread jonathan . gibbons
Changeset: 2443d24d096a Author:vromero Date: 2012-11-01 13:06 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2443d24d096a 6949443: visitTree assertion triggered using -Xjcov on small sample program Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/j