Re: Code Review Request for 6996769: support AEAD ciphers

2012-11-06 Thread Weijun Wang
CipherCore.java: 79 * update() must buffer this many bytes before before starting Dup "before". 380 AlgorithmParameters getParameters(String algName) The updated code does not return null anymore. Is there some other reason out of this patch? The init() method below seems to suppor

Re: RFR, 8001579, eliminated compiler warnings in the JDK native security code

2012-11-06 Thread Chris Hegarty
Changes look good to me. If no one on the security team has a problem with this, I can sponsor the change for John. -Chris. On 11/05/2012 09:34 PM, John Zavgren wrote: All: Please consider the following minor modifications to the compiler warning code changes: http://cr.openjdk.java.net/~che

Re: Transitioning the default keystore format to PKCS#12

2012-11-06 Thread Michael StJohns
At 03:52 PM 11/5/2012, Vincent Ryan wrote: >On 05/11/2012 18:28, Michael StJohns wrote: >>At 09:17 AM 11/5/2012, Vincent Ryan wrote: >>>Thanks for your suggestion Mike. I quite like that approach but I'm >>>concerned that existing tools and >>>browsers do not support this new type of PKCS12 safe b

hg: jdk8/tl/langtools: 8002286: Regression: Fix for 8000931 causes a JCK test failure

2012-11-06 Thread maurizio . cimadamore
Changeset: 9b85813d2262 Author:mcimadamore Date: 2012-11-06 14:45 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9b85813d2262 8002286: Regression: Fix for 8000931 causes a JCK test failure Summary: Wrong type used as 'site' in Resolve.resolveMethod Reviewed-by: jjg ! s

[PATCH] for bug 2376501: Krb5LoginModule config class does not return proper KDC list from DNS

2012-11-06 Thread Severin Gehwolf
Hi, In Config.java, line 1234 in method getKDCFromDNS(String realm) there is a loop which discards earlier values of KDCs returned rather than concatenating them. This results in a behaviour where only one KDC in a seemingly random fashion is returned. In fact, the KDC returned depends on the orde

Re: RFR, 8001579, eliminated compiler warnings in the JDK native security code

2012-11-06 Thread Sean Mullan
Valerie or Vinnie are probably the best ones from the security team to give this a once over since most of the changes are in pkcs11. --Sean On 11/6/12 9:15 AM, Chris Hegarty wrote: > Changes look good to me. If no one on the security team has a problem > with this, I can sponsor the change for

Re: Transitioning the default keystore format to PKCS#12

2012-11-06 Thread Vincent Ryan
On 6 Nov 2012, at 14:21, Michael StJohns wrote: > At 03:52 PM 11/5/2012, Vincent Ryan wrote: >> On 05/11/2012 18:28, Michael StJohns wrote: >>> At 09:17 AM 11/5/2012, Vincent Ryan wrote: Thanks for your suggestion Mike. I quite like that approach but I'm concerned that existing tools a

hg: jdk8/tl/jdk: 8002297: sun/net/www/protocol/http/StackTraceTest.java fails intermittently

2012-11-06 Thread chris . hegarty
Changeset: 157506182fa7 Author:chegar Date: 2012-11-06 21:01 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/157506182fa7 8002297: sun/net/www/protocol/http/StackTraceTest.java fails intermittently Reviewed-by: alanb, dsamersoff ! test/sun/net/www/protocol/http/StackTraceTest

Re: Transitioning the default keystore format to PKCS#12

2012-11-06 Thread Michael StJohns
At 02:20 PM 11/6/2012, Vincent Ryan wrote: >> A certificate unpaired with a private key will not be imported with existing >> tools. (MS certmgr and firefox/thunderbird). If its paired with a private >> key, it gets imported into the personal cert portion of the certificate >> store. It's po

Re: [PATCH] for bug 2376501: Krb5LoginModule config class does not return proper KDC list from DNS

2012-11-06 Thread Weijun Wang
Hi Severin The fix looks fine. There is one place it might get enhanced: if (value.charAt(j) == ':') { kdcs = (value.substring(0, j)).trim(); } So this changes a.com:88 to a.com. If the port is really 88, it's OK. Otherwise, info gets lost. Maybe we can keep the who

hg: jdk8/tl/langtools: 7198690: missing compiler message

2012-11-06 Thread jonathan . gibbons
Changeset: 55a007aaf63d Author:jjg Date: 2012-11-06 17:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55a007aaf63d 7198690: missing compiler message Reviewed-by: jjh ! src/share/classes/com/sun/tools/javac/main/Main.java

Re: Code review request for JEP-121

2012-11-06 Thread Valerie (Yu-Ching) Peng
Vinnie, I noticed the following after you putback, if you agree w/ my comments, please include them in the follow up TBD bug fixes for JEP-121. - I believe this class is used solely for the older PBE algorithms? If yes, its engineInit(...) should check that the PBEParameterSpec.getParameter

hg: jdk8/tl/hotspot: Added tag jdk8-b63 for changeset acabb5c282f5

2012-11-06 Thread lana . steuck
Changeset: 4d37eb50b9b1 Author:katleman Date: 2012-11-01 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4d37eb50b9b1 Added tag jdk8-b63 for changeset acabb5c282f5 ! .hgtags

hg: jdk8/tl/corba: 4 new changesets

2012-11-06 Thread lana . steuck
Changeset: de2b8def2be5 Author:ohair Date: 2012-10-26 14:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/de2b8def2be5 8000992: Update new build-infra makefiles Summary: Build-infra project integration. Multiple authors on this work: erikj and ihse primarily, also changes

hg: jdk8/tl: 7 new changesets

2012-11-06 Thread lana . steuck
Changeset: e64f2cb57d05 Author:ohair Date: 2012-10-26 14:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e64f2cb57d05 8000992: Update new build-infra makefiles Summary: Build-infra project integration. Multiple authors on this work: erikj and ihse primarily, also changes from

hg: jdk8/tl/langtools: 5 new changesets

2012-11-06 Thread lana . steuck
Changeset: 741cce355ba6 Author:ohair Date: 2012-10-26 14:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/741cce355ba6 8000992: Update new build-infra makefiles Summary: Build-infra project integration. Multiple authors on this work: erikj and ihse primarily, also cha

hg: jdk8/tl/jaxp: 3 new changesets

2012-11-06 Thread lana . steuck
Changeset: 121fc928a361 Author:ohair Date: 2012-10-26 14:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/121fc928a361 8000992: Update new build-infra makefiles Summary: Build-infra project integration. Multiple authors on this work: erikj and ihse primarily, also changes

hg: jdk8/tl/jaxws: 3 new changesets

2012-11-06 Thread lana . steuck
Changeset: c30a7cb5c587 Author:ohair Date: 2012-10-26 14:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c30a7cb5c587 8000992: Update new build-infra makefiles Summary: Build-infra project integration. Multiple authors on this work: erikj and ihse primarily, also changes

hg: jdk8/tl/jdk: 6355584: Introduce constrained Kerberos delegation

2012-11-06 Thread weijun . wang
Changeset: a1bbb8805e22 Author:weijun Date: 2012-11-07 14:13 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a1bbb8805e22 6355584: Introduce constrained Kerberos delegation Reviewed-by: valeriep + src/share/classes/com/sun/security/jgss/ExtendedGSSCredential.java ! src/share/