Code review request: 8004235: Disable native JGSS provider on Mac

2012-12-07 Thread Weijun Wang
The native JGSS provider on Mac is not ready yet. Disable the native lib creation. Please review the code changes at http://cr.openjdk.java.net/~weijun/8004235/webrev.00/ *build-dev*: I don't know how to write 2 ifneq on a single line. Thanks Max

Re: Code review request: 8004235: Disable native JGSS provider on Mac

2012-12-07 Thread Kelly O'Hair
Looks ok to me. Thanks. -kto On Dec 7, 2012, at 2:39 AM, Weijun Wang wrote: > The native JGSS provider on Mac is not ready yet. Disable the native lib > creation. Please review the code changes at > > http://cr.openjdk.java.net/~weijun/8004235/webrev.00/ > > *build-dev*: I don't know how t

hg: jdk8/tl/jdk: 8003881: Prevent lambda implementing inner classes from allowing the creation of new instances

2012-12-07 Thread robert . field
Changeset: 896d4af2ebfd Author:rfield Date: 2012-12-06 21:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/896d4af2ebfd 8003881: Prevent lambda implementing inner classes from allowing the creation of new instances Summary: Lambda implementing inner classes now has private

Re: Code review request: 8004235: Disable native JGSS provider on Mac

2012-12-07 Thread Erik Joelsson
From a build point of view, this looks ok. I don't know of an easy way to write 2 ifneqs on the same line either. The way you did it is at least readable and as far as I know the common way of doing it in make. /Erik On 2012-12-07 11:39, Weijun Wang wrote: The native JGSS provider on Mac is

[8] Code Review Request for 8004064: Downgrade normative references to ${java.home}/lib/security/java.security

2012-12-07 Thread Sean Mullan
As part of the effort to prepare the platform for modules (see http://openjdk.java.net/jeps/162) we need to re-examine all normative references to files/resources in ${java.home} as these may be candidates to be replaced or candidates to move to module-private locations in the future. The foc

Re: Code Review Request for 6996769: support AEAD ciphers

2012-12-07 Thread Valerie (Yu-Ching) Peng
Max, The webrev has been updated so that different key + iv values have to be used for AES/GCM encryption. Latest version at: http://cr.openjdk.java.net/~valeriep/6996769/webrev.03/ Please review and send me comments. Thanks! Valerie On 11/07/12 21:50, Valerie (Yu-Ching) Peng wrote: Max, Up