These tests started failing recently on some mac machines. They appear
to hang and timeout.
FAILED:
sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh
FAILED:
sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.sh
Webrev:
http
Comments so far, will send more as I review more:
AlgorithmId.java
* Update copyright
KeyStore.java
[296] I think you want to say:
If none was set then null is returned.
As I understand it, if none is set, then the KeyStore provider will use
a default algorithm as specified by the Security
Changeset: be443002e970
Author:mcimadamore
Date: 2013-01-22 16:23 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/be443002e970
8006673: TargetType52 fails because of bad golden file
Summary: Fix golden file in negative test
Reviewed-by: jjg
! test/tools/javac/lambda/Tar
Changeset: b61e5f801f7c
Author:mcimadamore
Date: 2013-01-22 16:39 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b61e5f801f7c
8006684: Compiler produces java.lang.VerifyError: Bad type on operand stack
Summary: Lambda desugaring generates spurious references to 'this' i
More comments:
KeyStore.java
[551, 670, 753] Needs to make a copy (clone) according to javadoc, so
should be:
this.attributes = Collections.unmodifiableSet(new HashSet<>(attributes));
--Sean
On 01/22/2013 11:24 AM, Sean Mullan wrote:
Comments so far, will send more as I review more:
Algor
I've made those changes. Thanks.
On 22 Jan 2013, at 16:24, Sean Mullan wrote:
> Comments so far, will send more as I review more:
>
> AlgorithmId.java
>
> * Update copyright
>
> KeyStore.java
>
> [296] I think you want to say:
>
> If none was set then null is returned.
>
> As I understand
Correct.
Thanks.
On 22 Jan 2013, at 16:50, Sean Mullan wrote:
> More comments:
>
> KeyStore.java
>
> [551, 670, 753] Needs to make a copy (clone) according to javadoc, so should
> be:
>
> this.attributes = Collections.unmodifiableSet(new HashSet<>(attributes));
>
> --Sean
>
> On 01/22/2013
More comments ...
PKCS12Attribute.java:
[213-215] You can replace this with Arrays.hashCode(byte[]).
--Sean
On 01/22/2013 11:50 AM, Sean Mullan wrote:
More comments:
KeyStore.java
[551, 670, 753] Needs to make a copy (clone) according to javadoc, so
should be:
this.attributes = Collections
Changeset: 22e417cdddee
Author:ohrstrom
Date: 2013-01-18 00:16 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/22e417cdddee
8004658: Add internal smart javac wrapper to solve JEP 139
Reviewed-by: jjg
! make/build.properties
! make/build.xml
+ src/share/classes/com/sun/t
That's better.
Thanks.
On 22/01/2013 18:22, Sean Mullan wrote:
More comments ...
PKCS12Attribute.java:
[213-215] You can replace this with Arrays.hashCode(byte[]).
--Sean
On 01/22/2013 11:50 AM, Sean Mullan wrote:
More comments:
KeyStore.java
[551, 670, 753] Needs to make a copy (clone) a
Last call on this. And an updated webrev containing a minor javadoc
change to the Implementer's Note in PrivateKey and SecretKey.
Webrev: http://cr.openjdk.java.net/~vinnie/6263419/webrev.01/
Thanks.
On 17/01/2013 17:04, Vincent Ryan wrote:
Hello,
Please review the fix for 6263419. It intro
Final set of comments in this webrev:
PKCS12KeyStore.java
[214] Minor comment, but I think it would be cleaner to create separate
SecretKeyEntry and PrivateKeyEntry classes.
[224, 235-238, 519, 533-536]
For the attributes, I think it would be cleaner (and faster) to pass
Collections.emptySe
I don't think you should add the @since 1.8 tags on the Destroyable
methods, since they are not new, you are just adding a default
implementation.
As an aside, we should file an RFE to add a default method for
SecretKey.getFormat that returns "RAW" (since this is what should always
be returne
On 22/01/2013 21:30, Sean Mullan wrote:
I don't think you should add the @since 1.8 tags on the Destroyable
methods, since they are not new, you are just adding a default
implementation.
Removed tags.
As an aside, we should file an RFE to add a default method for
SecretKey.getFormat that ret
On 22/01/2013 17:05, Vincent Ryan wrote:
I've made those changes. Thanks.
On 22 Jan 2013, at 16:24, Sean Mullan wrote:
:
KeyStore.java
[296] I think you want to say:
If none was set then null is returned.
As I understand it, if none is set, then the KeyStore provider will use a
default a
Last call and an updated webrev that includes the review comments:
Webrev: http://cr.openjdk.java.net/~vinnie/8006591/webrev.01/
On 18/01/2013 19:53, Vincent Ryan wrote:
Hello,
Please review the fix for 8006591. It introduces a mechanism to enable
stronger PBE algorithms to be specified when
Changeset: 8ee6d45348ba
Author:vinnie
Date: 2013-01-22 23:32 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8ee6d45348ba
6263419: No way to clean the memory for a java.security.Key
Reviewed-by: mullan
! src/share/classes/java/security/PrivateKey.java
! src/share/classes/java
Changeset: c18f28312c49
Author:smarks
Date: 2013-01-22 18:30 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c18f28312c49
8005646: TEST_BUG:
java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup leaves
process running
Reviewed-by: mchung
! test/java/rmi/activ
Changeset: 8943b4213f59
Author:jjg
Date: 2013-01-22 18:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8943b4213f59
8006723: sjavac test fails to compile on clean build
Reviewed-by: ksrini
! test/tools/sjavac/SJavac.java
+ test/tools/sjavac/SJavacWrapper.java
Changeset: f5b70712e0d5
Author:jjg
Date: 2013-01-22 19:06 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f5b70712e0d5
8006728: temporarily workaround jtreg problems for doclint tests in othervm
Reviewed-by: jjh
+ test/tools/doclint/html/AAA.java
+ test/tools/doclint/ti
Changeset: 919afffa70b0
Author:sherman
Date: 2013-01-22 20:59 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/919afffa70b0
8003680: JSR 310 Date/Time API
Summary: Integration of JSR310 Date/Time API for M6
Reviewed-by: alanb, naoto, dholmes
Contributed-by: scolebou...@joda.org
Changeset: 8209c91b751d
Author:sherman
Date: 2013-01-22 21:02 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/8209c91b751d
8003680: JSR 310 Date/Time API
Summary: Integration of JSR310 Date/Time API for M6
Reviewed-by: alanb, naoto, dholmes
Contributed-by: scolebou...@joda.org, ro
22 matches
Mail list logo
