hg: jdk8/tl/jdk: 8007786: JDK-8002048 testcase doesn't work on Solaris

2013-02-12 Thread dmitry . samersoff
Changeset: f7fb173ac833 Author:dsamersoff Date: 2013-02-12 16:02 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f7fb173ac833 8007786: JDK-8002048 testcase doesn't work on Solaris Summary: test built in into Solaris shell doesn't have -e operator Reviewed-by: sla, sspitsyn !

hg: jdk8/tl/langtools: 8006334: javap, JavapTask constructor breaks with null pointer exception if parameter options is null

2013-02-12 Thread vicente . romero
Changeset: 073696f59241 Author:vromero Date: 2013-02-12 13:36 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/073696f59241 8006334: javap, JavapTask constructor breaks with null pointer exception if parameter options is null Reviewed-by: jjg ! src/share/classes/com/sun

Re: RFR: JDK-8007607

2013-02-12 Thread John Zavgren
On 02/08/2013 01:34 PM, Dmitry Samersoff wrote: John, Ideas? It's a JNI so just throw OOM. -Dmitry On 2013-02-08 21:38, John Zavgren wrote: Although I agree that the name: "GSS_C_NO_CHANNEL_BINDINGS" is misleading, I can't identify anything else that seems more appropriate. The header fil

Re: RFR: JDK-8007607

2013-02-12 Thread Dmitry Samersoff
John, Changing everything for throw OOM is the right goal but it's a huge work to do - it's meaningless to throw OOM if all callers doesn't check for exception. I'm in doubt it could be done all at once and probably this problem should go to the huge TODO pile. So I'm speaking about *one particu

Re: RFR: JDK-8007607

2013-02-12 Thread John Zavgren
Thanks, Dmitry. If I were to rewrite the native code to throw exceptions, in the areas I indicated, and no one caught them, would that create any problems. I have the code in my sandbox right now for throwing them. If I can retain that in a graceful way, that seems like a prudent thing to do, i

hg: jdk8/tl/jdk: 8007392: JSR 310: DateTime API Updates; ...

2013-02-12 Thread xueming . shen
Changeset: 7dcb74c3ffba Author:sherman Date: 2013-02-12 09:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7dcb74c3ffba 8007392: JSR 310: DateTime API Updates 8007520: Update date/time classes in j.util and j.sql packages 8007572: Replace existing jdk timezone data at /lib/

hg: jdk8/tl: 8007392: JSR 310: DateTime API Updates

2013-02-12 Thread xueming . shen
Changeset: fdb1e09519ed Author:sherman Date: 2013-02-12 09:27 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/fdb1e09519ed 8007392: JSR 310: DateTime API Updates Summary: Integration of JSR310 Date/Time API for M7 Reviewed-by: darcy, alanb, naoto Contributed-by: scolebou...@joda.o

hg: jdk8/tl/langtools: 8007464: Add graph inference support

2013-02-12 Thread maurizio . cimadamore
Changeset: 2154ed9ff6c8 Author:mcimadamore Date: 2013-02-12 19:25 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2154ed9ff6c8 8007464: Add graph inference support Summary: Add support for more aggressive type-inference scheme Reviewed-by: jjg ! src/share/classes/com/su

Re: [8] code review for 8007934: algorithm parameters for PBE Scheme 2 not decoded correctly in PKCS12 keystore

2013-02-12 Thread Sean Mullan
A couple of comments: mapPBEParamsToAlgorithm should be a static method. Instead of catching the IOException and falling back, couldn't you instead look at the algorithm OID (on line 328 & 1954) and determine if it is PBE or PBES2 (and pass that in as an additional parameter)? --Sean On 02/

Re: [8] code review for 8007934: algorithm parameters for PBE Scheme 2 not decoded correctly in PKCS12 keystore

2013-02-12 Thread Vincent Ryan
Thanks Sean. Updated webrev: http://cr.openjdk.java.net/~vinnie/8007934/webrev.01/ On 12/02/2013 20:19, Sean Mullan wrote: A couple of comments: mapPBEParamsToAlgorithm should be a static method. Changed both mapPBExxx methods. Instead of catching the IOException and falling back, could

Re: [8] code review for 8007934: algorithm parameters for PBE Scheme 2 not decoded correctly in PKCS12 keystore

2013-02-12 Thread Sean Mullan
Looks good. --Sean On 02/12/2013 03:59 PM, Vincent Ryan wrote: Thanks Sean. Updated webrev: http://cr.openjdk.java.net/~vinnie/8007934/webrev.01/ On 12/02/2013 20:19, Sean Mullan wrote: A couple of comments: mapPBEParamsToAlgorithm should be a static method. Changed both mapPBExxx metho

Re: RFR: JDK-8007607

2013-02-12 Thread Dmitry Samersoff
John, On 2013-02-12 21:11, John Zavgren wrote: > If I were to rewrite the native code to throw exceptions, in the > areas I indicated, and no one caught them, would that create any > problems. I have the code in my sandbox right now for throwing them. > If I can retain that in a graceful way, that

Re: RFR: JDK-8007607

2013-02-12 Thread Valerie (Yu-Ching) Peng
Well, although it's huge effort to fix and catch all the malloc calls, I think it's still better to start somewhere. Note that for the list of sources that you have in your webrev, they aren't linked against libjvm and libjava, and thus you need to use local utility method(s) for throwing the

hg: jdk8/tl/langtools: 8008077: update reference impl for type-annotations

2013-02-12 Thread jonathan . gibbons
Changeset: bc456436c613 Author:jjg Date: 2013-02-12 17:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bc456436c613 8008077: update reference impl for type-annotations Reviewed-by: jjg Contributed-by: wmdi...@cs.washington.edu ! src/share/classes/com/sun/tools/classf