hg: jdk8/tl/jdk: 8016370: javadoc warnings, unexpected mostly

2013-06-12 Thread alan . bateman
Changeset: f56b5c243f7c Author:alanb Date: 2013-06-12 08:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f56b5c243f7c 8016370: javadoc warnings, unexpected mostly Reviewed-by: martin, jjg ! makefiles/scripts/genExceptions.sh ! src/share/classes/java/nio/Buffer.java ! src/

hg: jdk8/tl/jdk: 8016369: java/lang/instrument/RetransformBigClass.sh failing again

2013-06-12 Thread alan . bateman
Changeset: 6df79b7bae6f Author:alanb Date: 2013-06-12 09:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6df79b7bae6f 8016369: java/lang/instrument/RetransformBigClass.sh failing again Reviewed-by: sla, sergei ! test/java/lang/instrument/MakeJAR4.sh

hg: jdk8/tl/jaxws: 8013021: Rebase 8005432 & 8003542 against the latest jdk8/jaxws; ...

2013-06-12 Thread chris . hegarty
Changeset: 8f2986ff0235 Author:mkos Date: 2013-06-12 14:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/8f2986ff0235 8013021: Rebase 8005432 & 8003542 against the latest jdk8/jaxws 8003542: Improve processing of MTOM attachments 8005432: Update access to JAX-WS Reviewed-b

Re: Status update: BigInteger performance enhancements

2013-06-12 Thread Sean Mullan
(cc-ing security-dev for comments) Original thread is at http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/017912.html --Sean On 06/12/2013 11:17 AM, Brian Burkhalter wrote: On Jun 12, 2013, at 6:19 AM, Florian Weimer wrote: On 06/11/2013 11:31 PM, Brian Burkhalter wrote: W

Re: Code review request: 8014310: JAAS/Krb5LoginModule using des encytypes failure with NPE after JDK-8012679

2013-06-12 Thread Valerie (Yu-Ching) Peng
Changes look fine. Just curious, what's the reason for the changes in KeyTab.java? Valerie On 06/07/13 00:31, Weijun Wang wrote: Ding dong. On 5/27/13 10:06 AM, Weijun Wang wrote: Please review the code changes at http://cr.openjdk.java.net/~weijun/8014310/webrev.00/ The reason is that

hg: jdk8/tl/jdk: 8010325: Remove hash32() method and hash32 int field from java.lang.String

2013-06-12 Thread mike . duigou
Changeset: c9f5a2fd7d3d Author:bchristi Date: 2013-06-12 11:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9f5a2fd7d3d 8010325: Remove hash32() method and hash32 int field from java.lang.String Reviewed-by: alanb, mduigou ! src/share/classes/java/lang/String.java ! src/s

Re: Code review request: 8014310: JAAS/Krb5LoginModule using des encytypes failure with NPE after JDK-8012679

2013-06-12 Thread Wang Weijun
在 Jun 13, 2013,4:14 AM,"Valerie (Yu-Ching) Peng" 写道: > > Changes look fine. > Just curious, what's the reason for the changes in KeyTab.java? There was an EType.getDefaults() call there and it is useless. If kept, will need to check exception. -Max > Valerie > > On 06/07/13 00:31, Weijun

hg: jdk8/tl/jdk: 8016448: java/util/BitSet/BitSetStreamTest.java no longer compiles, missed by 8015895

2013-06-12 Thread mike . duigou
Changeset: ce8fbca80bbc Author:henryjen Date: 2013-06-12 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce8fbca80bbc 8016448: java/util/BitSet/BitSetStreamTest.java no longer compiles, missed by 8015895 Reviewed-by: mduigou ! test/java/util/BitSet/BitSetStreamTest.jav

Re: Code review request: 8014310: JAAS/Krb5LoginModule using des encytypes failure with NPE after JDK-8012679

2013-06-12 Thread Valerie (Yu-Ching) Peng
Ok, I have no more comments. Thanks, Valerie On 06/12/13 15:16, Wang Weijun wrote: > > 在 Jun 13, 2013,4:14 AM,"Valerie (Yu-Ching) Peng" 写道: > >> Changes look fine. >> Just curious, what's the reason for the changes in KeyTab.java? > There was an EType.getDefaults() call there and it is useless.

Re: Code Review Request for 7196805: DH Key interoperability testing between SunJCE and JsafeJCE not successful

2013-06-12 Thread Weijun Wang
Hi Valerie Not sure if we really need to fix the equals() method here. Is there a spec saying the equality is based on internal fields instead of encoded bytes? I am saying this because it's not easy to get equals() correct here. In DHPrivateKey.java, the new equals() requires the other obje

hg: jdk8/tl/jdk: 2 new changesets

2013-06-12 Thread weijun . wang
Changeset: 021fdd093cd9 Author:weijun Date: 2013-06-13 09:59 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/021fdd093cd9 8014310: JAAS/Krb5LoginModule using des encytypes failure with NPE after JDK-8012679 Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/Config.j

Code review request: 6727821: javax.security.auth.login.Configuration keeps reference to context ClassLoader

2013-06-12 Thread Weijun Wang
Hi All Please review this code change http://cr.openjdk.java.net/~weijun/6727821/webrev.00/ Storing a thread-related variable into a static field is not sensible. A similar problem in javax.security.auth.Policy, but the class is already @Deprecated. If you believe it had better be fixed, I