Re: Code review request, 8017049: rename property jdk.tls.rejectClientInitializedRenego

2013-06-26 Thread Vincent Ryan
Your fix looks good. On 26 Jun 2013, at 04:45, Xuelei Fan wrote: > Hi, > > webrev: http://cr.openjdk.java.net/~xuelei/8017049/webrev.00/ > > In update of 7188658 > (http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a76858faad59), we defines a > new system property, "jdk.tls.rejectClientInitializedRene

Re: On 8017264: Java app crash on it's startup after Java updated to 7u25 from 7u21

2013-06-26 Thread David Holmes
Max, Is a minidump available (not that I know how to work with them but they are more reliable than stack traces) ? I suspect the symbolic information in the stacktrace is reflecting closest available symbol rather than actual symbol. As you say the sequence of calls don't really make sense.

Re: On 8017264: Java app crash on it's startup after Java updated to 7u25 from 7u21

2013-06-26 Thread Weijun Wang
Hi David I'm able to reproduce the problem on my computer and has pinpointed the exact Win32 API failing: The LSA login function returns a ticket with size 131074 bytes. Normally a ticket is smaller than several KB. There must be something wrong. It's a windows-i586 JRE running on a windows-

Re: On 8017264: Java app crash on it's startup after Java updated to 7u25 from 7u21

2013-06-26 Thread David Holmes
On 26/06/2013 10:44 PM, Weijun Wang wrote: Hi David I'm able to reproduce the problem on my computer and has pinpointed the exact Win32 API failing: The LSA login function returns a ticket with size 131074 bytes. Normally a ticket is smaller than several KB. There must be something wrong. Does

hg: jdk8/tl/jdk: 8017049: rename property jdk.tls.rejectClientInitializedRenego

2013-06-26 Thread xuelei . fan
Changeset: 0822bcddbd4f Author:xuelei Date: 2013-06-26 06:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0822bcddbd4f 8017049: rename property jdk.tls.rejectClientInitializedRenego Reviewed-by: vinnie, wetmore, mullan ! src/share/classes/sun/security/ssl/Handshaker.java !

Re: 8017325, 8017326: Cleanup of javadoc tag

2013-06-26 Thread Jason Uh
Nithya, Thanks for catching that. I've labeled the bugs with noreg-doc. Jason On 6/25/13 9:25 PM, Nithya Srinivasan wrote: Jason Can you please add the appropriate noreg- label for the 2 bugs - JDK-8017325 & JDK-8017326 Thanks Nithya On 6/25/2013 1:32 PM, Joe Darcy wrote: Hi Jason, The ja

hg: jdk8/tl/jdk: 8013836: getFirstDayOfWeek reports wrong day for pt-BR locale

2013-06-26 Thread yong . huang
Changeset: 510035b7 Author:yhuang Date: 2013-06-25 21:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/510035b7 8013836: getFirstDayOfWeek reports wrong day for pt-BR locale Reviewed-by: naoto + src/share/classes/sun/util/resources/pt/CalendarData_pt_BR.properties !

Re: Smart Cards in Java Kerberos

2013-06-26 Thread Henry B. Hotz
Even easier. Just set useTicketCache=true in the JAAS config. On Jun 25, 2013, at 5:37 PM, Weijun Wang wrote: > Java (at least Oracle JDK) does not support PKINIT. > > Yes, you can do it outside, create a KerberosTicket and a KerberosPrincipal, > create a JAAS Subject containing them, and cal

hg: jdk8/tl/jdk: 8016761: Lambda metafactory - incorrect type conversion of constructor method handle

2013-06-26 Thread robert . field
Changeset: 71059bca036a Author:rfield Date: 2013-06-26 07:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71059bca036a 8016761: Lambda metafactory - incorrect type conversion of constructor method handle Reviewed-by: jrose ! src/share/classes/java/lang/invoke/InnerClassLa

hg: jdk8/tl/jdk: 8012647: Add Arrays.parallelPrefix (prefix sum, scan, cumulative sum)

2013-06-26 Thread chris . hegarty
Changeset: e83cdd58f1cf Author:chegar Date: 2013-06-26 15:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e83cdd58f1cf 8012647: Add Arrays.parallelPrefix (prefix sum, scan, cumulative sum) Reviewed-by: chegar, alanb, psandoz Contributed-by: Doug Lea , Tristan Yan , Chris H

Re: getCodeBase broken locally in 7 update 25

2013-06-26 Thread Phillip Thomas
Sandeep Konchady writes: > > Hi Mickey, > The issue you are seeing is intended behavior. This was caused because of a vulnerability that was fixed in 7u25 in which which a  getCodeBase call against all local applet/jnlp apps will return null. > > > Thanks, > Sandeep > > > On Jun 19, 2013,

hg: jdk8/tl/jdk: 8017322: java/util/Currency/PropertiesTest.sh should run exclusively

2013-06-26 Thread naoto . sato
Changeset: 336e5a862013 Author:naoto Date: 2013-06-26 11:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/336e5a862013 8017322: java/util/Currency/PropertiesTest.sh should run exclusively Reviewed-by: alanb ! test/TEST.ROOT

Re: [8] code review request for 7165807: Non optimized initialization of NSS crypto library leads to scalability issues

2013-06-26 Thread Vincent Ryan
Thanks for the review Valerie. Comments below. On 26 Jun 2013, at 00:23, Valerie (Yu-Ching) Peng wrote: > > > - The private static native boolean nssInit(...) method should be removed? It > seems obsolete by nssInitWithOptions(...) and I didn't see it being used > anywhere. Same goes for the

hg: jdk8/tl/langtools: 8016908: TEST_BUG: removing non-ascii characters causes tests to fail

2013-06-26 Thread kumar . x . srinivasan
Changeset: c2d9303c3477 Author:ksrini Date: 2013-06-26 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c2d9303c3477 8016908: TEST_BUG: removing non-ascii characters causes tests to fail Reviewed-by: jjg, vromero ! test/tools/javac/api/6437999/T6437999.java - test/

hg: jdk8/tl/jdk: 7018139: Fix HTML accessibility and doclint issues in java.math

2013-06-26 Thread joe . darcy
Changeset: 1fda8fa7ae97 Author:darcy Date: 2013-06-26 13:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1fda8fa7ae97 7018139: Fix HTML accessibility and doclint issues in java.math Reviewed-by: lancea, bpb ! src/share/classes/java/math/BigDecimal.java ! src/share/classes/

Re: [8] code review request for 7165807: Non optimized initialization of NSS crypto library leads to scalability issues

2013-06-26 Thread Valerie (Yu-Ching) Peng
Sure, zapping the nssInit() for only JDK 8 is fine. Being a private static method, I doubt that its removal will break anything though. Thanks, Valerie On 06/26/13 11:38, Vincent Ryan wrote: Thanks for the review Valerie. Comments below. On 26 Jun 2013, at 00:23, Valerie (Yu-Ching) Peng wrot

hg: jdk8/tl/langtools: 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values

2013-06-26 Thread jonathan . gibbons
Changeset: 3b2e10524627 Author:jjg Date: 2013-06-26 18:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b2e10524627 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values Reviewed-by: jjg, darcy Contributed-by: matherey.nu..

hg: jdk8/tl/jdk: 8019223: Fix doclint warnings in java.rmi.server

2013-06-26 Thread joe . darcy
Changeset: a5aa57eb85b6 Author:darcy Date: 2013-06-26 19:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5aa57eb85b6 8019223: Fix doclint warnings in java.rmi.server Reviewed-by: smarks ! src/share/classes/java/rmi/server/RMIClassLoader.java

Review Request: JDK-8019227: JDK-8010325 broke the old build

2013-06-26 Thread Brad Wetmore
Brent/Alan/Mike, Hashing.java was removed from the JDK workspace, but was not removed from the old java/java/FILES_java.gmk. Things that still depend on the old build (JCE/deploy) are currently broken. http://cr.openjdk.java.net/~wetmore/8019227/webrev.00/ Brad P.S. I'm very aware that we

hg: jdk8/tl/langtools: 8014230: Compilation incorrectly succeeds with inner class constructor with 254 parameters

2013-06-26 Thread eric . mccorkle
Changeset: c674b396827c Author:emc Date: 2013-06-27 00:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c674b396827c 8014230: Compilation incorrectly succeeds with inner class constructor with 254 parameters Summary: The compiler does not account fr extra parameters d

hg: jdk8/tl/jdk: 8019228: Fix doclint issues in java.util.zip

2013-06-26 Thread joe . darcy
Changeset: ac65905883a7 Author:darcy Date: 2013-06-26 22:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac65905883a7 8019228: Fix doclint issues in java.util.zip Reviewed-by: sherman, mchung ! src/share/classes/java/util/zip/Deflater.java ! src/share/classes/java/util/zip

Re: Review Request: JDK-8019227: JDK-8010325 broke the old build

2013-06-26 Thread Alan Bateman
On 27/06/2013 05:37, Brad Wetmore wrote: Brent/Alan/Mike, Hashing.java was removed from the JDK workspace, but was not removed from the old java/java/FILES_java.gmk. Things that still depend on the old build (JCE/deploy) are currently broken. http://cr.openjdk.java.net/~wetmore/8019227/webr