hg: jdk8/tl/jdk: 8017141: java.util/stream Spliterators from sequential sources should not catch OOME

2013-07-09 Thread paul . sandoz
Changeset: 628432ee4d68 Author:henryjen Date: 2013-07-09 09:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/628432ee4d68 8017141: java.util/stream Spliterators from sequential sources should not catch OOME Reviewed-by: mchung Contributed-by: paul.san...@oracle.com ! src/s

Request for review: 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5

2013-07-09 Thread Weijun Wang
Hi All An NPE was suppressed in jdk8 with a simple if. This new fix tries to output useful info even for a null argument. Please review the code changes at http://cr.openjdk.java.net/~weijun/8019267/webrev.01/ The added test makes sure logging does not crash and the output is information

hg: jdk8/tl/jdk: 8019551: Make BaseStream public

2013-07-09 Thread paul . sandoz
Changeset: 44a634c1edc4 Author:psandoz Date: 2013-07-09 10:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44a634c1edc4 8019551: Make BaseStream public Reviewed-by: chegar, psandoz Contributed-by: brian goetz ! src/share/classes/java/util/stream/AbstractPipeline.java ! sr

Re: Request for review: 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5

2013-07-09 Thread Sean Mullan
Looks fine. --Sean On 07/09/2013 03:32 AM, Weijun Wang wrote: Hi All An NPE was suppressed in jdk8 with a simple if. This new fix tries to output useful info even for a null argument. Please review the code changes at http://cr.openjdk.java.net/~weijun/8019267/webrev.01/ The added test

Re: 7u40 Review Request for 8017173: XMLCipher with RSA_OAEP Key Transport algorithm can't be instantiated

2013-07-09 Thread Vincent Ryan
Your fix looks good. On 8 Jul 2013, at 21:48, Sean Mullan wrote: > Hi Xuelei, > > Can you please review my fix for JDK-8017173? This is a regression introduced > in 7u25. It does not affect JDK 8, because the recent fix for JDK-8011547 to > integrate the Apache Santuario release 1.5.4 also fi

RFR : 8019979 : Replace CheckPackageAccess test with better one from closed repo

2013-07-09 Thread Seán Coffey
I'd like to move this testcase from our internal test repo and replace the current "test/java/lang/SecurityManager/CheckPackageAccess.java" testcase . It's a straightforward test to ensure that the package restrictions enforced via the java.security file are those expected. The testcase should

Re: RFR : 8019979 : Replace CheckPackageAccess test with better one from closed repo

2013-07-09 Thread Sean Mullan
Looks good to me. --Sean On 07/09/2013 09:28 AM, Seán Coffey wrote: I'd like to move this testcase from our internal test repo and replace the current "test/java/lang/SecurityManager/CheckPackageAccess.java" testcase . It's a straightforward test to ensure that the package restrictions enforced

hg: jdk8/tl/jdk: 8019370: Sync j.u.c Fork/Join from 166 to tl

2013-07-09 Thread paul . sandoz
Changeset: 43134e79c0bb Author:psandoz Date: 2013-07-09 16:04 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43134e79c0bb 8019370: Sync j.u.c Fork/Join from 166 to tl Reviewed-by: chegar, martin Contributed-by: Doug Lea ! src/share/classes/java/util/concurrent/AbstractExecu

hg: jdk8/tl/jdk: 8019979: Replace CheckPackageAccess test with better one from closed repo

2013-07-09 Thread sean . coffey
Changeset: 83c2976ef8ee Author:coffeys Date: 2013-07-09 16:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83c2976ef8ee 8019979: Replace CheckPackageAccess test with better one from closed repo Reviewed-by: mullan ! test/java/lang/SecurityManager/CheckPackageAccess.java

hg: jdk8/tl/langtools: 8020214: TEST_BUG: test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java broken

2013-07-09 Thread kumar . x . srinivasan
Changeset: aedb3bb327d5 Author:ksrini Date: 2013-07-09 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aedb3bb327d5 8020214: TEST_BUG: test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java broken Reviewed-by: jjg ! test/tools/javap/8007907/JavapReturn

hg: jdk8/tl/jaxp: 8016648: FEATURE_SECURE_PROCESSING set to true or false causes SAXParseException to be thrown

2013-07-09 Thread huizhe . wang
Changeset: 3b071f506ab9 Author:joehw Date: 2013-07-09 16:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/3b071f506ab9 8016648: FEATURE_SECURE_PROCESSING set to true or false causes SAXParseException to be thrown Summary: jaxp 1.5 feature update Reviewed-by: alanb, dfuchs,

Re: Code Review Requests for 7196382 and 8010134

2013-07-09 Thread Valerie (Yu-Ching) Peng
Xuelei, I got side-tracked w/ other bugs before coming back to this one. I have updated the webrev to incorporate your review comments, including 1) auto-adjust the default keysize when it's out of range 2) apply our own range checking besides the native limit checking I also noticed that the D

hg: jdk8/tl/jdk: 8016341: java/lang/ref/OOMEInReferenceHandler.java failing intermittently

2013-07-09 Thread david . holmes
Changeset: 7bb17aa9a09f Author:dholmes Date: 2013-07-09 22:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bb17aa9a09f 8016341: java/lang/ref/OOMEInReferenceHandler.java failing intermittently Summary: Ensure WeakRef object can't be prematurely gc'd Reviewed-by: chegar, pl