[JDK 8] Code review request 7188657, There should be a way to reorder the JSSE ciphers

2013-08-28 Thread Xuelei Fan
Hi, Please review this update to support cipher suites reorder: webrev: http://cr.openjdk.java.net/~xuelei/7188657/webrev.00/ Two new methods are added to SSLParameters: public final void setUseCipherSuitesOrder(boolean honorOrder); public final boolean getUseCipherSuitesOrder(); If SSLPa

Re: [JDK 8] Code review request 7188657, There should be a way to reorder the JSSE ciphers

2013-08-28 Thread Florian Weimer
On 08/28/2013 11:02 AM, Xuelei Fan wrote: Hi, Please review this update to support cipher suites reorder: webrev: http://cr.openjdk.java.net/~xuelei/7188657/webrev.00/ Two new methods are added to SSLParameters: public final void setUseCipherSuitesOrder(boolean honorOrder); public fina

Re: [JDK 8] Code review request 7188657, There should be a way to reorder the JSSE ciphers

2013-08-28 Thread Xuelei Fan
On 8/28/2013 5:57 PM, Florian Weimer wrote: > On 08/28/2013 11:02 AM, Xuelei Fan wrote: >> Hi, >> >> Please review this update to support cipher suites reorder: >> >> webrev: http://cr.openjdk.java.net/~xuelei/7188657/webrev.00/ >> >> Two new methods are added to SSLParameters: >> public final

hg: jdk8/tl/jdk: 8023717: (process) ProcessBuilder should catch SecurityException rather than AccessControlException

2013-08-28 Thread alan . bateman
Changeset: 2efa310226f7 Author:alanb Date: 2013-08-28 14:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2efa310226f7 8023717: (process) ProcessBuilder should catch SecurityException rather than AccessControlException Reviewed-by: wetmore, alanb Contributed-by: marti...@go

hg: jdk8/tl/jdk: 8022594: Potential deadlock in of sun.nio.ch.Util/IOUtil

2013-08-28 Thread alan . bateman
Changeset: 378acd4d03c8 Author:alanb Date: 2013-08-28 15:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/378acd4d03c8 8022594: Potential deadlock in of sun.nio.ch.Util/IOUtil Reviewed-by: chegar ! src/macosx/classes/sun/nio/ch/KQueueArrayWrapper.java ! src/macosx/classes/

hg: jdk8/tl/jdk: 8023713: ZipFileSystem crashes on old zip file

2013-08-28 Thread xueming . shen
Changeset: 690b2931baef Author:sherman Date: 2013-08-28 09:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/690b2931baef 8023713: ZipFileSystem crashes on old zip file Summary: to handle extra data field copy correctly even the extra data does not follow the spec Reviewed-b

hg: jdk8/tl/jdk: 8023528: Rename Comparator combinators to disambiguate overloading methods

2013-08-28 Thread henry . jen
Changeset: be2d25a277a7 Author:henryjen Date: 2013-08-21 20:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be2d25a277a7 8023528: Rename Comparator combinators to disambiguate overloading methods Reviewed-by: mduigou, smarks ! src/share/classes/java/util/Comparator.java !

Re: [kitten] Fwd: Kitten Digest, Vol 104, Issue 14

2013-08-28 Thread Sam Hartman
> "Mayank" == Mayank Upadhyay writes: Mayank>Hi Weijun, You point out a legitimate problem, but I want Mayank> to understand a couple of assumptions: 1. Why allow only Mayank> initSecContext() and acceptSecContext() to have this new Mayank> behavior? Imagine a mechanism bu

hg: jdk8/tl/jdk: 8023275: Wrapping collections should override default methods

2013-08-28 Thread henry . jen
Changeset: ade440668f94 Author:henryjen Date: 2013-08-26 22:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ade440668f94 8023275: Wrapping collections should override default methods Reviewed-by: mduigou, psandoz ! src/share/classes/java/util/Collections.java + test/java/u

hg: jdk8/tl/langtools: 8014566: Remove @ignore tags from MethodReference66 and InInterface when 8013875 is fixed

2013-08-28 Thread henry . jen
Changeset: 7de7100c30ce Author:henryjen Date: 2013-08-28 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de7100c30ce 8014566: Remove @ignore tags from MethodReference66 and InInterface when 8013875 is fixed Reviewed-by: briangoetz, jjg ! test/tools/javac/lambda/

hg: jdk8/tl/jdk: 8023155: Ensure functional consistency across Random, ThreadLocalRandom, SplittableRandom

2013-08-28 Thread paul . sandoz
Changeset: b1f41565b806 Author:psandoz Date: 2013-08-28 22:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1f41565b806 8023155: Ensure functional consistency across Random, ThreadLocalRandom, SplittableRandom Reviewed-by: mduigou Contributed-by: Doug Lea , Paul Sandoz

hg: jdk8/tl/langtools: 8010310: [javadoc] Error processing sources with -private

2013-08-28 Thread jonathan . gibbons
Changeset: 189942cdf585 Author:jjg Date: 2013-08-28 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/189942cdf585 8010310: [javadoc] Error processing sources with -private Reviewed-by: vromero, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java !

Re: Code review request: 8012615: Realm.getRealmsList returns realms list in wrong

2013-08-28 Thread Henry B. Hotz
I can't speak to the code, but your description of what *should* happen is correct. I have no experience with complex X-relam setups (which have security issues even if the code is correct), but I do know that the MIT code does not "nest" its processing of the capath configuration which causes

Re: Code review request: 8012615: Realm.getRealmsList returns realms list in wrong

2013-08-28 Thread Valerie (Yu-Ching) Peng
Thanks for the clarification on MIT's result on the test cases. So, for majority of the test cases inside the regression test, we return different results from what MIT returns? That's a little unsettling. How about for the more complicated valid capaths definition? We for sure will return th

Re: Code review request: 8012615: Realm.getRealmsList returns realms list in wrong

2013-08-28 Thread Weijun Wang
On 8/29/13 10:37 AM, Valerie (Yu-Ching) Peng wrote: Thanks for the clarification on MIT's result on the test cases. So, for majority of the test cases inside the regression test, we return different results from what MIT returns? That's a little unsettling. Well that's about the chaining Ja