hg: jdk8/tl/jdk: 8029057: test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError

2013-11-26 Thread yuka . kamiya
Changeset: 4d9078b1f25b Author:peytoia Date: 2013-11-26 14:49 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d9078b1f25b 8029057: test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError Reviewed-by: okutsu - test/java/text/Bidi/Bug6665028.java

hg: jdk8/tl/langtools: 8028428: strictfp allowed as annotation element modifier

2013-11-26 Thread joel . franck
Changeset: 3ea55d523981 Author:jfranck Date: 2013-11-26 13:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3ea55d523981 8028428: strictfp allowed as annotation element modifier Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java + test/tools/java

hg: jdk8/tl/langtools: 2 new changesets

2013-11-26 Thread jan . lahoda
Changeset: 8acb838c9b79 Author:jlahoda Date: 2013-11-26 15:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8acb838c9b79 8026374: javac accepts void as a method parameter Summary: Changing Check.validate to reject void types. Reviewed-by: jjg, vromero ! src/share/clas

RFR: 8029181: ts.sh generates invalid file after JDK-8027026

2013-11-26 Thread Weijun Wang
Please take a look at http://cr.openjdk.java.net/~weijun/8029181/webrev.00/ Not really harmful, but still an error. Thanks Max

Re: RFR: 8029181: ts.sh generates invalid file after JDK-8027026

2013-11-26 Thread Vincent Ryan
Hello Max, Your fix looks good. Thanks. On 26 Nov 2013, at 15:06, Weijun Wang wrote: > Please take a look at > > http://cr.openjdk.java.net/~weijun/8029181/webrev.00/ > > Not really harmful, but still an error. > > Thanks > Max

Re: RFR: 8029181: ts.sh generates invalid file after JDK-8027026

2013-11-26 Thread Sean Mullan
Looks good, but please make sure to add the "teststabilization" label to the bug before you push. --Sean On 11/26/2013 10:06 AM, Weijun Wang wrote: Please take a look at http://cr.openjdk.java.net/~weijun/8029181/webrev.00/ Not really harmful, but still an error. Thanks Max

Re: RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-26 Thread Alan Bateman
On 26/11/2013 16:23, Volker Simonis wrote: Hi, thanks to everybody for the prompt and helpful reviews. Here comes the final webrev which incorporates all the corrections and suggestions from the second review round: http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/ I've successfully buil

Re: RFR: 8029181: ts.sh generates invalid file after JDK-8027026

2013-11-26 Thread Weijun Wang
I can do that. Is "teststabilization" equivalent to "noreg-self" now? I thought it is used by a test that intermittently fails, at least that fails. --Max On 11/26/13, 23:58, Sean Mullan wrote: Looks good, but please make sure to add the "teststabilization" label to the bug before you push.

hg: jdk8/tl/hotspot: 15 new changesets

2013-11-26 Thread lana . steuck
Changeset: 854a42db7069 Author:amurillo Date: 2013-11-15 07:58 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/854a42db7069 8028444: new hotspot build - hs25-b60 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 570aaefce624 Author:morris Date: 2013-11-18 1

Code Review Request: 8021418

2013-11-26 Thread Rajan Halade
May I request you to review this simple change - http://cr.openjdk.java.net/~juh/rajan/8021418/ The test is modified to set SO_REUSEADDR on ServerSocket to false for stabilization. Thanks, Rajan

Re: Code Review Request: 8025763

2013-11-26 Thread Bradford Wetmore
Tony, I note the @since's are missing for the new methods, both in the generated output in the overridden methods (i.e. no javadoc), and the methods in which you've changed the behavior (i.e. new javadoc). I'm not sure what you can do about the previous behavior (cc'ing Mike/Sowmya, maybe th

hg: jdk8/tl/jdk: 8029181: ts.sh generates invalid file after JDK-8027026

2013-11-26 Thread weijun . wang
Changeset: 1738dfb0c52a Author:weijun Date: 2013-11-27 09:56 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1738dfb0c52a 8029181: ts.sh generates invalid file after JDK-8027026 Reviewed-by: vinnie, mullan ! test/sun/security/tools/jarsigner/TimestampCheck.java

Re: Code Review Request: 8021418

2013-11-26 Thread Xuelei Fan
This change looks fine. JSSE regression tests use a lot of code as "new ServerSocket(0)", we may want a cleanup for test stabilization. Xuelei On 11/27/2013 9:13 AM, Rajan Halade wrote: > May I request you to review this simple change - > > http://cr.openjdk.java.net/~juh/rajan/8021418/ >

Re: Code Review Request: 8021418

2013-11-26 Thread Rajan Halade
On 11/26/2013 18:09, Xuelei Fan wrote: This change looks fine. thanks! JSSE regression tests use a lot of code as "new ServerSocket(0)", we may want a cleanup for test stabilization. I will look at regression tests and file separate bug for it. - Rajan Xuelei On 11/27/2013 9:13 AM, Rajan