RFR 8029369: Shell tests in sun/security/pkcs11/ do not compile PKCS11Test

2013-12-02 Thread Vincent Ryan
Please review this trivial fix to correct a recently exposed dependency on test execution order, for a small number of PKCS11 tests: Webrev: http://cr.openjdk.java.net/~vinnie/8029369/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8029369 Thanks.

Re: RFR 8029369: Shell tests in sun/security/pkcs11/ do not compile PKCS11Test

2013-12-02 Thread Sean Mullan
Looks fine to me. --Sean On 12/02/2013 06:42 AM, Vincent Ryan wrote: Please review this trivial fix to correct a recently exposed dependency on test execution order, for a small number of PKCS11 tests: Webrev: http://cr.openjdk.java.net/~vinnie/8029369/webrev.00/ Bug: https://bugs.openjdk.jav

hg: jdk8/tl/jdk: 8029369: Shell tests in sun/security/pkcs11/ do not compile PKCS11Test

2013-12-02 Thread vincent . x . ryan
Changeset: 4ca1027a130a Author:vinnie Date: 2013-12-02 14:19 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ca1027a130a 8029369: Shell tests in sun/security/pkcs11/ do not compile PKCS11Test Reviewed-by: mullan ! test/sun/security/pkcs11/KeyStore/Basic.sh ! test/sun/securit

hg: jdk8/tl/jdk: 8025211: Intermittent test failure: java/net/DatagramSocket/PortUnreachable.java

2013-12-02 Thread mark . sheppard
Changeset: 39b3b0e77af5 Author:msheppar Date: 2013-12-02 14:01 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39b3b0e77af5 8025211: Intermittent test failure: java/net/DatagramSocket/PortUnreachable.java Summary: modified test to execute in a single thread to eliminate potent

Re: Code Review Request: 8025763

2013-12-02 Thread Mike Duigou
The missing @since for overridden methods and missing @throws for unchecked exceptions is a known javadoc behaviour. Apparently there's some disagreement as to whether it is a bug but I encourage you to add the tags. Mike On Nov 27 2013, at 12:55 , Bradford Wetmore wrote: > Sean wrote: > >

hg: jdk8/tl/jdk: 8028368: There is no description whether or not java.util.ResourceBundle is thread-safe

2013-12-02 Thread naoto . sato
Changeset: 5b5ee2288306 Author:naoto Date: 2013-12-02 11:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5b5ee2288306 8028368: There is no description whether or not java.util.ResourceBundle is thread-safe Reviewed-by: okutsu ! src/share/classes/java/util/ListResourceBund

Re: Redundant check in java.security.BasicPermission.implies()

2013-12-02 Thread Sean Mullan
On 12/01/2013 08:08 PM, Tom Hawtin wrote: On 29/11/2013 20:29, Alex Yursha wrote: The javadocs for the class java.security.BasicPermission says, that the naming convention for BasicPermission names follows the hierarchical property naming convention with possible wildcards. AFAIU, *hierarchical

hg: jdk8/tl/jdk: 8029417: JDBC 4.2 javadoc updates

2013-12-02 Thread lance . andersen
Changeset: bcf5fa5e9509 Author:lancea Date: 2013-12-02 16:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcf5fa5e9509 8029417: JDBC 4.2 javadoc updates Reviewed-by: darcy ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/DriverManager.java !

RFR 8029158: sun/security/pkcs11/Signature/TestDSAKeyLength.java does not compile (or run)

2013-12-02 Thread Valerie (Yu-Ching) Peng
Please help review this regression test fix which addresses the setting on test utility classes as well as skip testing against newer NSS libraries for a problem with NSS. The webrev can be found at: http://cr.openjdk.java.net/~valeriep/8029158/webrev.00/ Thanks, Valerie