See: http://cr.openjdk.java.net/~mullan/webrevs/8025708/webrev/
This fixes a problem with the PKIX CertPathBuilder where it wasn't able
to build a path when the Authority Key Identifier extension of an
intermediate CA cert did not contain a serial number field, and the end
entity cert did.
T
The number of native code warnings in the build is annoying so this is
another drive-by fix that eliminates a few of them in the serviceability
and security areas. The webrev with the changes is here:
http://cr.openjdk.java.net/~alanb/8034856+8034857/webrev/
In the pkcs11 code the issue is t
Changes look good.
/Staffan
On 13 feb 2014, at 14:18, Alan Bateman wrote:
>
> The number of native code warnings in the build is annoying so this is
> another drive-by fix that eliminates a few of them in the serviceability and
> security areas. The webrev with the changes is here:
>
> http
Looks fine to me.
--Sean
On 02/13/2014 08:18 AM, Alan Bateman wrote:
The number of native code warnings in the build is annoying so this is
another drive-by fix that eliminates a few of them in the serviceability
and security areas. The webrev with the changes is here:
http://cr.openjdk.java.
On 13/02/2014 17:56, Mikael Vidstedt wrote:
Alan,
I made the change to JarFacade.c myself last week, only to then see the comment
a few lines above where you added the new include. It seems to indicate that
including ctype.h on Solaris/SPARC is a bad idea. I have no idea if the comment
is sti
Alan,
I made the change to JarFacade.c myself last week, only to then see the comment
a few lines above where you added the new include. It seems to indicate that
including ctype.h on Solaris/SPARC is a bad idea. I have no idea if the comment
is still relevant, but that may be worth understand
On 02/11/2014 02:18 PM, Valerie (Yu-Ching) Peng wrote:
Please see comments inline.
On 02/10/14 16:30, Anthony Scarpino wrote:
On 02/10/2014 03:04 PM, Valerie (Yu-Ching) Peng wrote:
Well, there are some changes that look strange which I need more time to
figure out.
For example, the purpose f
On 2014-02-13 10:23, Alan Bateman wrote:
On 13/02/2014 17:56, Mikael Vidstedt wrote:
Alan,
I made the change to JarFacade.c myself last week, only to then see
the comment a few lines above where you added the new include. It
seems to indicate that including ctype.h on Solaris/SPARC is a bad
Can someone please review the fixes which checks for pending exceptions
in native code "pcsc_md.c"?
The fix is trivial scope-wise.
Webrev: http://cr.openjdk.java.net/~valeriep/8033571/webrev.00/
Thanks,
Valerie
Can someone please review the fixes which checks for pending exceptions
in native code "pcsc.c"?
The fix is straightforward for all except the changes under
Java_sun_security_smartcardio_PCSC_SCardGetStatusChange(...) method
which is somewhat complicated due to the need to free up memories.
Updated webrev at
http://cr.openjdk.java.net/~weijun/8034033/webrev.01/
Thanks
Max
On Feb 13, 2014, at 8:56, Wang Weijun wrote:
>
> On Feb 13, 2014, at 8:48, Valerie (Yu-Ching) Peng
> wrote:
>
>> Max,
>>
>> Changes look fine.
>> However, I noticed some calls which may throw exceptions
Hi Sean,
Looks good to me, but I'm not an official Reviewer.
I have a couple of questions, though.
1. This isn't a part of your change, but shouldn't the comment on line
200 of AdaptableX509CertSelector.java read "As for version 3,..." and
not "As for version 2,..."?
2. Just curious, any re
12 matches
Mail list logo
