Re: RFR: 8034033: [parfait] JNI exception pending in share/native/sun/security/krb5/nativeccache.c

2014-02-18 Thread Wang Weijun
Ping again. On Feb 15, 2014, at 16:18, Wang Weijun wrote: > Webrev updated again at > > http://cr.openjdk.java.net/~weijun/8034033/webrev.02/ > > I add more checks to make sure it's a good initial TGT, and exit the loop > when there is either an exception or the TGT is found. So there will

Re: RFR: 8034033: [parfait] JNI exception pending in share/native/sun/security/krb5/nativeccache.c

2014-02-18 Thread Valerie (Yu-Ching) Peng
Changes look fine. Thanks, Valerie On 02/18/14 17:02, Wang Weijun wrote: Ping again. On Feb 15, 2014, at 16:18, Wang Weijun wrote: Webrev updated again at http://cr.openjdk.java.net/~weijun/8034033/webrev.02/ I add more checks to make sure it's a good initial TGT, and exit the loop whe

Re: Review Request for JDK-8033571: [parfait] warning from b128 for security/smartcardio/pcsc_md.c: JNI exception pending

2014-02-18 Thread Valerie (Yu-Ching) Peng
Hmm, good question. When I checked JNI spec, it turns out that it didn't list any JNI exception under JNIEnv->GetStringUTFChars(...). Since this JNI method Java_sun_security_smartcardio_PlatformPCSC_initialize(..) does not return any object, perhaps we should throw some exception here to indi

Re: Review Request for JDK-8033571: [parfait] warning from b128 for security/smartcardio/pcsc_md.c: JNI exception pending

2014-02-18 Thread Xuelei Fan
On 2/19/2014 10:34 AM, Valerie (Yu-Ching) Peng wrote: > > Hmm, good question. > When I checked JNI spec, it turns out that it didn't list any JNI > exception under JNIEnv->GetStringUTFChars(...). > Since this JNI method > Java_sun_security_smartcardio_PlatformPCSC_initialize(..) does not > return