Re: Code Review Request: 7107611 sun.security.pkcs11.SessionManager is scalability blocker

2014-02-21 Thread Valerie (Yu-Ching) Peng
Where can I find the updated webrev? As for the performance test, I think we can probably try a "worse-case" (say 5000 Cipher objects which we don't re-use, just create, do operation, and then discard) and "best-case" (same # of objects, but re-use) against both impls and see how much a diffe

Re: Code Review Request: 7107611 sun.security.pkcs11.SessionManager is scalability blocker

2014-02-21 Thread Anthony Scarpino
On 02/21/2014 02:38 PM, Valerie (Yu-Ching) Peng wrote: Where can I find the updated webrev? Oops.. thought I included it: http://cr.openjdk.java.net/~ascarpino/7107611/webrev.01/ As for the performance test, I think we can probably try a "worse-case" (say 5000 Cipher objects which we don't

Re: Review Request for JDK-8030114: [parfait] warnings from b119 for jdk.src.share.native.sun.security.smartcardio: JNI exception pending

2014-02-21 Thread Valerie (Yu-Ching) Peng
Good points, I have updated the webrev accordingly. The current callers of Java_sun_security_smartcardio_PCSC_SCardGetStatusChange seems to only pass 1 reader at a time, so I just moved the free call to a separate loop as part of cleanup. Webrev is updated at: http://cr.openjdk.java.net/~va