RFR 8036971: krb5.conf does not accept directive lines before the first section

2014-03-10 Thread Wang Weijun
Please review the fix at http://cr.openjdk.java.net/~weijun/8036971/webrev.00/ bug is https://bugs.openjdk.java.net/browse/JDK-8036971 Before the enhancement JDK-8029994 is available, a bug fix is needed. Thanks Max

Re: CipherInputStream for AEAD modes is insecure (GCM, etc.): ciphertext tampering without detection possible

2014-03-10 Thread Tim Whittington
On 10/03/2014, at 1:12 pm, Xuelei Fan wrote: > On 3/10/2014 2:31 AM, Tim Whittington wrote: >> >> On 9/03/2014, at 10:50 pm, Tim Whittington >> > > wrote: >> >>> >>> On 7/03/2014, at 9:14 am, Philipp Heckel >> > wrot

Re: CipherInputStream for AEAD modes is insecure (GCM, etc.): ciphertext tampering without detection possible

2014-03-10 Thread Xuelei Fan
Hi Tim, Sorry, I should have been cleaner on this point. What I wanted to express is that I understood your concerns. Thanks for the detailed description and examples. Thanks, Xuelei On 3/10/2014 3:37 PM, Tim Whittington wrote: > > On 10/03/2014, at 1:12 pm, Xuelei Fan wrote: > >> On 3/10/2

Re: RFR 8036971: krb5.conf does not accept directive lines before the first section

2014-03-10 Thread Xuelei Fan
Looks fine to me. Xuelei On 3/10/2014 3:35 PM, Wang Weijun wrote: > Please review the fix at > >http://cr.openjdk.java.net/~weijun/8036971/webrev.00/ > > bug is > >https://bugs.openjdk.java.net/browse/JDK-8036971 > > Before the enhancement JDK-8029994 is available, a bug fix is needed

Re: [9] Request for Review: 8021804: Certpath validation fails if validity period of root cert does not include validity period of intermediate cert

2014-03-10 Thread Sean Mullan
Hi Jason, Sorry for the delay in reviewing this. On 02/28/2014 02:54 PM, Jason Uh wrote: Hi Sean, Could I please get a review of this change? This fix allows a certpath to be validated when a certificate issued by a version 1 trusted cert has a validity period that doesn't fall within the vali

Re: [9] Request for Review: 8021804: Certpath validation fails if validity period of root cert does not include validity period of intermediate cert

2014-03-10 Thread Jason Uh
Thanks, Sean. I've simplified my changes to only removing the call to setValidityPeriod. http://cr.openjdk.java.net/~juh/8021804/webrev.01 Jason On 3/10/14 12:00 PM, Sean Mullan wrote: Hi Jason, Sorry for the delay in reviewing this. On 02/28/2014 02:54 PM, Jason Uh wrote: Hi Sean, Could