Code review request, a simple fix to remove the incorrect comment in RSAClientKeyExchange.java

2014-04-29 Thread Xuelei Fan
Hi, As this is a simple comment fix, I will not generate a webrev as general. In sun/security/ssl/RSAClientKeyExchange.java: 116 // Cannot generate key here, please don't use Cipher.UNWRAP_MODE! 117 cipher.init(Cipher.UNWRAP_MODE, privateKey, 118 new TlsRsaPremasterSecretParameterS

Re: Review request: 8040059 Change default policy for extensions to no permission

2014-04-29 Thread Alan Bateman
On 25/04/2014 00:07, Mandy Chung wrote: Thanks Sean. I have updated the webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8040059/webrev.01/ Erik - I'm including build-dev to review the build change for java.policy file. Just catching up on this thread. The update to ZipFileSystem and

Re: Code review request, a simple fix to remove the incorrect comment in RSAClientKeyExchange.java

2014-04-29 Thread Sean Mullan
Looks fine to me. --Sean On 04/29/2014 10:05 AM, Xuelei Fan wrote: Hi, As this is a simple comment fix, I will not generate a webrev as general. In sun/security/ssl/RSAClientKeyExchange.java: 116 // Cannot generate key here, please don't use Cipher.UNWRAP_MODE! 117 cipher.init(Cipher.UNW

JDK 9 Review Request for 8038349: Signing XML with DSA throws Exception when key is larger than 1024 bits

2014-04-29 Thread Sean Mullan
Please review the following change which adds support for 2048-bit DSA keys and the DSA-SHA256 algorithm to the XML Signature implementation: webrev: http://cr.openjdk.java.net/~mullan/webrevs/8038349/webrev.00/ JDK 8 already includes the underlying support for both of these in the Sun provide

Re: JDK 9 Review Request for 8038349: Signing XML with DSA throws Exception when key is larger than 1024 bits

2014-04-29 Thread Xuelei Fan
Minor comments. algorithms/implementations/SignatureDSA.java 51 public static final String URI = XMLSignature.ALGO_ID_SIGNATURE_DSA; With this update, this variable can be declared as private, I think. Is it still necessary to define this variable