Re: JDK 9 Review Request for 8038349: Signing XML with DSA throws Exception when key is larger than 1024 bits

2014-05-01 Thread Xuelei Fan
> security/utils/JavaUtils.java > = The updated code is a straightforward move from other classes in order to remove the duplicated code. Looks fine but we might want to make a few little enhancements within this fix. 162 public static byte[] convertASN1toXMLDSIG(byte

Re: JDK 9 Review Request for 8038349: Signing XML with DSA throws Exception when key is larger than 1024 bits

2014-05-01 Thread Sean Mullan
On 05/01/2014 10:12 AM, Xuelei Fan wrote: security/utils/JavaUtils.java = The updated code is a straightforward move from other classes in order to remove the duplicated code. Looks fine but we might want to make a few little enhancements within this fix. 162 publi

Re: JDK 9 Review Request for 8038349: Signing XML with DSA throws Exception when key is larger than 1024 bits

2014-05-01 Thread Xuelei Fan
My fault. I read the "l" (L) in the following line as "1" (one). >> 225 byte asn1Bytes[] = new byte[6 + j + l]; Xuelei On 5/2/2014 3:10 AM, Sean Mullan wrote: >> 225 byte asn1Bytes[] = new byte[6 + j + l]; >> By the line, the length of the target byte array is known. I might >> p