Hi, Jeremy.
As an "Author", you can create a changeset but you can't push to the repo until
you're a "Committer". Additional details about the differences between Author
and Committer may be found here [1,2].
The diffs to create a changeset are (of course) in your webrev. Your Sponsor
can us
On 05/28/2014 12:47 AM, Weijun Wang wrote:
On 5/28/2014 3:46, Sean Mullan wrote:
Ok. The fix looks fine to me, though it looks like the code in the 2
methods is very similar - could it be refactored into a common method?
Yes, it's now
http://cr.openjdk.java.net/~weijun/8036709/webrev.02/
I’ll begin reviewing your changeset and get back to you.
Thanks.
On 28 May 2014, at 16:28, Jeremy Manson wrote:
> Ah, okay. Thanks, Iris. I should already know known that - Martin has
> explained it to me before.
>
> Vincent - let me know how you want to proceed.
>
> Jeremy
>
>
> On Tue,
It’s difficult to develop a useful test that is cross-platform so let’s skip
the testcase for this fix.
On 28 May 2014, at 17:21, Jeremy Manson wrote:
> You can defer the change if you need to. I'm going on vacation from the 6th
> to the 16th, so there are timing issues around that.
>
> At
Hello!
The argument 'reset' of javax.smartcardio.Card#disconnect has the
reverse logic: When it is true, the card is not reset and vice versa.
Would you please help review the trivial fix for this issue?
BUGURL: https://bugs.openjdk.java.net/browse/JDK-7047033
WEBREV: http://cr.openjdk.java.ne
One additional change:
In pcsc_multi2jstring() it is better to make sure the whole parsed
buffer is null-terminates.
This way we can guarantee that in the following line we will not access
memory outside the buffer:
js = (*env)->NewStringUTF(env, tab[cnt]);
Would you please he
Looks good.
Valerie
On 05/28/14 13:39, Ivan Gerasimov wrote:
Hello!
The argument 'reset' of javax.smartcardio.Card#disconnect has the
reverse logic: When it is true, the card is not reset and vice versa.
Would you please help review the trivial fix for this issue?
BUGURL: https://bugs.openjd
Changes look fine.
Thanks,
Valerie
On 05/28/14 14:00, Ivan Gerasimov wrote:
One additional change:
In pcsc_multi2jstring() it is better to make sure the whole parsed
buffer is null-terminates.
This way we can guarantee that in the following line we will not
access memory outside the buffer:
AFAIK, this searchSubject utility function is looking for the requested
GSSCredentialSpi objects (not GSSCredentialImpl object which contains a
Hashtable of GSSCredentialSpi objects and their keys).
When creating the Subject object ourselves, we only convert and stores
Kerberos-specific cred
Hi,
I was researching a StackOverflow question [1] and I came across some behaviour
with the validation of certificate chains that I don't quite understand.
I have a chain consisting of a root certificate with validity period
1999->2019; an intermediate certificate with validity period 2004->202
Hi Robert,
This was actually fixed in
https://bugs.openjdk.java.net/browse/JDK-8021804 and is pending a
backport to JDK 7u.
Thanks,
Jason
On 5/28/14 4:04 PM, Robert Gibson wrote:
Hi,
I was researching a StackOverflow question [1] and I came across some behaviour
with the validation of cert
On May 29, 2014, at 7:25, Valerie (Yu-Ching) Peng
wrote:
>
> AFAIK, this searchSubject utility function is looking for the requested
> GSSCredentialSpi objects (not GSSCredentialImpl object which contains a
> Hashtable of GSSCredentialSpi objects and their keys).
The method returns GSSCrede
12 matches
Mail list logo
