Re: RFR 8044755: Add a test for algorithm constraints check in jarsigner

2014-06-05 Thread Wang Weijun
On Jun 4, 2014, at 16:26, Wang Weijun wrote: > Oh, I was just updating the webrev to > > http://cr.openjdk.java.net/~weijun/8044755/webrev.01/ Are you OK with this 2nd version of webrev? Thanks Max > > As we've just discussed offline, the reason the 2nd jarsigner call fails is a > double

Re: RFR 8044755: Add a test for algorithm constraints check in jarsigner

2014-06-05 Thread Xuelei Fan
On 6/5/2014 3:24 PM, Wang Weijun wrote: > > On Jun 4, 2014, at 16:26, Wang Weijun wrote: > >> Oh, I was just updating the webrev to >> >> http://cr.openjdk.java.net/~weijun/8044755/webrev.01/ > > Are you OK with this 2nd version of webrev? > Ok. Xuelei > Thanks > Max > >> >> As we've just

Re: Locking/Singleton in JCAUtil

2014-06-05 Thread Sean Mullan
On 05/22/2014 08:34 PM, Bernd Eckenfels wrote: Hello, by browsing the source code I run across the JCAUtil class. It is (among other stuff) responsible for providing a SecureRandom singleton. The code looks a bit strange. First of all, it defines a LOCK object, but instead of using an unreachab

Re: Webrev request: JDK-8015081

2014-06-05 Thread Sean Mullan
On 06/04/2014 07:29 PM, Jamil Nimeh wrote: Hello all, This is an update to the webrev for JDK-8015081 that takes into account review changes and adds a few more tests. http://cr.openjdk.java.net/~ascarpino/8015081/webrev.03 [1012]