RFR 8023197: Pre-configured command line options for keytool and jarsigner

2014-06-06 Thread Wang Weijun
Please review the code changes in http://cr.openjdk.java.net/~weijun/8023197/webrev.02 This enhancement allows you to put frequently used keytool/jarsigner options into a property file and use -conf to load it. Like this: # A Pre-configured options file keytool.all = -storepass:env PASS -

RFR: 8044747: [TESTBUG] Test sun/security/tools/policytool/i18n.sh fails after clicking 'Done' button in test frame

2014-06-06 Thread Wang Weijun
Please review the fix at http://cr.openjdk.java.net/~weijun/8044747/webrev.00 which is just a simple -if [ -e $HOME/.java.policy ]; then +if [ -f $HOME/.java.policy ]; then I always forget that Solaris sh does not support test -e. Thanks Max

Re: RFR: 8044747: [TESTBUG] Test sun/security/tools/policytool/i18n.sh fails after clicking 'Done' button in test frame

2014-06-06 Thread Xuelei Fan
Looks fine to me. Xuelei On 6/6/2014 4:58 PM, Wang Weijun wrote: > Please review the fix at > >http://cr.openjdk.java.net/~weijun/8044747/webrev.00 > > which is just a simple > > -if [ -e $HOME/.java.policy ]; then > +if [ -f $HOME/.java.policy ]; then > > I always forget that Solaris sh

Re: RFR 8023197: Pre-configured command line options for keytool and jarsigner

2014-06-06 Thread Xuelei Fan
src/share/classes/sun/security/tools/KeyStoreUtil.java == 224 throw new IOException("Cannot have both " + c1 + " and " + c2); "Cannot have both pre-configured options ..."? 176 st.whitespaceChars(0x00, 0x20); 177 st.wordChars(0x

Re: Webrev request: JDK-8015081

2014-06-06 Thread Jamil Nimeh
One more version of this webrev with minor comment changes: http://cr.openjdk.java.net/~ascarpino/8015081/webrev.04 Thanks, --Jamil On 06/04/2014 04:29 PM, Jamil Nimeh wrote: Hello all, This is an update to the webrev for JDK-8015081 that takes into account review changes and adds a few more