Thanks Sean.
Our existing PKCS11 tests are sufficient as regression tests so I’ve added
’noreg-self’.
Also, I didn’t set a subcomponent value as only the PKCS11 testsuite has
changed not
the PKCS11 implementation.
On 17 Jun 2014, at 19:55, Sean Mullan wrote:
> The bug needs a noreg label. Als
Just a few comments on Config.java:
479 if (dups.contains(file)) {
480 throw new IOException("Profile path included more than
once");
481 } else {
482 dups.add(file);
483 }
This could be compressed into one call as:
if (!dups.add(file)) {
On 06/18/2014 05:59 AM, Vincent Ryan wrote:
Thanks Sean.
Our existing PKCS11 tests are sufficient as regression tests so I’ve added
’noreg-self’.
Also, I didn’t set a subcomponent value as only the PKCS11 testsuite has
changed not
the PKCS11 implementation.
Hmm. I've always considered the su
OK. I’ve updated both bug reports.
On 18 Jun 2014, at 18:06, Sean Mullan wrote:
> On 06/18/2014 05:59 AM, Vincent Ryan wrote:
>> Thanks Sean.
>>
>> Our existing PKCS11 tests are sufficient as regression tests so I’ve added
>> ’noreg-self’.
>> Also, I didn’t set a subcomponent value as only th
Tony or Vinnie, either of you have time to review?
Thanks,
Valerie
On 5/15/2014 4:08 PM, Valerie (Yu-Ching) Peng wrote:
Can someone help reviewing this SunJCE provider fix? Essentially,
CipherCore class is updated to minimize memory allocation and data
copying. The fix has been verified agai
May I request you to review these 3 new tests to be added for PBE keys.
New tests are added to address following:
- seal/unseal works correctly with PBE algorithms
- key wrapper works correctly with PBEKey
- SecretKeyFactory.translateKey() method works
JDK Issue: https://bugs.openjdk.java.net/b
Sean,
Not sure if you can get to reviewing this before your vacation.
If not, I will find someone else to help...
Webrev: http://cr.openjdk.java.net/~valeriep/8043406/webrev.00/
Thanks,
Valerie
Tony,
Can you please help reviewing this trivial fix?
Changes are about overriding the SHA1withDSA signature upper limit to
1024 when larger DSA key size is supported.
Webrev: http://cr.openjdk.java.net/~valeriep/8046046/webrev.00/
Thanks,
Valerie
On 06/18/2014 04:04 PM, Valerie Peng wrote:
Tony,
Can you please help reviewing this trivial fix?
Changes are about overriding the SHA1withDSA signature upper limit to
1024 when larger DSA key size is supported.
Webrev: http://cr.openjdk.java.net/~valeriep/8046046/webrev.00/
Thanks,
Valerie
The code change looks fine. Do you think this is worth a regression
test? Since the in-place operation wasn't caught it sound like there
might be no in-place tests
Tony
On 06/18/2014 02:53 PM, Valerie Peng wrote:
Tony or Vinnie, either of you have time to review?
Thanks,
Valerie
On 5/15/2
On Jun 19, 2014, at 0:17, Sean Mullan wrote:
> Just a few comments on Config.java:
>
> 479 if (dups.contains(file)) {
> 480 throw new IOException("Profile path included more than once");
> 481 } else {
> 482 dups.add(file);
> 483 }
>
> This could
11 matches
Mail list logo
