Looks ok to me.
--Sean
On 06/18/2014 07:04 PM, Valerie Peng wrote:
Tony,
Can you please help reviewing this trivial fix?
Changes are about overriding the SHA1withDSA signature upper limit to
1024 when larger DSA key size is supported.
Webrev: http://cr.openjdk.java.net/~valeriep/8046046/webre
On 06/19/2014 01:39 AM, Wang Weijun wrote:
>570 public Void run() throws Exception {
>
>This can be declared to throw IOException, then you can change lines 586-591
to:
>
>throw pe.getException();
You mean javac will be smart enough to find out that pe's cause can only b
Webrev updated at
http://cr.openjdk.java.net/~weijun/8029994/webrev.02/
Besides your suggestions, I've changed the final line in the constructor from
throw new KrbException(joe)
to
202 if (DEBUG) {
203 System.out.println("Exception thrown in loading config:");
Looks good to me.
--Sean
On 06/19/2014 10:15 AM, Wang Weijun wrote:
Webrev updated at
http://cr.openjdk.java.net/~weijun/8029994/webrev.02/
Besides your suggestions, I've changed the final line in the constructor from
throw new KrbException(joe)
to
202 if (DEBUG) {
20
Please review the following simple changeset to identify the offending JAR file
following a signature verification error.
Previously, only the offending entry in the JAR was identified.
This helps during troubleshooting when several JAR files being processed.
The request was originally submitted
I shortened the output to display only the JAR filename to avoid leaking
filesystem information.
I’ve updated the webrev in-place.
Thanks.
On 19 Jun 2014, at 17:59, Vincent Ryan wrote:
> Please review the following simple changeset to identify the offending JAR
> file following a signature
Hello,
I'd prefer to see the CheckJarSigError.sh as a Java program.
Cheers,
-Joe
On 06/19/2014 02:21 PM, Vincent Ryan wrote:
I shortened the output to display only the JAR filename to avoid leaking
filesystem information.
I’ve updated the webrev in-place.
Thanks.
On 19 Jun 2014, at 17:59,
Hi Xuelei,
Could you please review this change?
webrev: http://cr.openjdk.java.net/~juh/7065233/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-7065233
I don't think any of the strings in the lines I changed would be
locale-sensitive. There are a few cases fixed here that weren't inclu
Hello all,
This revision for the fix for 8015081 has the following test changes:
Removal of the static byte buffers for serialized data in lieu of a more
dynamic approach. A stripped down version of Subject in its own package
is now being compiled alongside SubjectNullTests.java. This version
Looks fine to me.
Thanks,
Xuelei
On 6/20/2014 8:25 AM, Jason Uh wrote:
> Hi Xuelei,
>
> Could you please review this change?
> webrev: http://cr.openjdk.java.net/~juh/7065233/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-7065233
>
> I don't think any of the strings in the lines I c
10 matches
Mail list logo
