Re: RFR 7150092: NTLM authentication fail if user specified a different realm

2014-06-23 Thread Wang Weijun
Ping again. On Jun 12, 2014, at 14:07, Wang Weijun wrote: > Hi All > > Please review the code change at > > http://cr.openjdk.java.net/~weijun/7150092/webrev.00/ > > The problem is that in NTLM, the server might prompt for a domain name (in > Type 2 message), and the client can also provide

Re: RFR: 8047721: @since should have JDK version

2014-06-23 Thread Bradford Wetmore
I would prefer that JCE1.2 be pulled out completely in the Cipher* classes. I will be sending you a separate note about JCE logistics. Thanks for doing this cleanup. Brad On 6/20/2014 11:46 AM, Henry Jen wrote: Hi, Please review a trivial webrev to add JDK version to @since in a format as

Re: ThreadLocalRandom clinit troubles

2014-06-23 Thread Bradford Wetmore
Martin, Thanks for filing. I was positive there was already a bug for this, but for the life of me I can't find it now. There's some other more minor cleanup that needs to take place, but seems like I've been in escalation/firefighting mode for more than a year now and it hasn't bubbled to

Re: RFR 8043406: Change default policy for JCE providers to run with as few privileges,as possible

2014-06-23 Thread Mandy Chung
Valerie, On 6/20/14 4:57 PM, Mandy Chung wrote: Yes please file a bug and it does look like a bug in the loadLibrary. I'll look into it. It'd be helpful if you can include a stack trace in the JBS issue without granting FilePermission to access all files. I have a patch and going to send

Re: RFR: 8047721: @since should have JDK version

2014-06-23 Thread Henry Jen
OK, I'll remove all @since JCE line, as the class already has @since 1.4 as Joe pointed out earlier. Uodated webrev at http://cr.openjdk.java.net/~henryjen/jdk9/8047721/2/webrev/ Cheers, Henry On 06/23/2014 10:04 AM, Bradford Wetmore wrote: I would prefer that JCE1.2 be pulled out completel

Re: RFR: 8047721: @since should have JDK version

2014-06-23 Thread Joe Darcy
Looks good to me; thanks, -Joe On 06/23/2014 01:50 PM, Henry Jen wrote: OK, I'll remove all @since JCE line, as the class already has @since 1.4 as Joe pointed out earlier. Uodated webrev at http://cr.openjdk.java.net/~henryjen/jdk9/8047721/2/webrev/ Cheers, Henry On 06/23/2014 10:04 AM,

Re: RFR: 8047721: @since should have JDK version

2014-06-23 Thread Bradford Wetmore
JCE (Cipher) changes look good to me. Let me know if there's any problem with the point I mentioned in the other email. Brad On 6/23/2014 1:50 PM, Henry Jen wrote: OK, I'll remove all @since JCE line, as the class already has @since 1.4 as Joe pointed out earlier. Uodated webrev at http:

Re: RFR: 8047721: @since should have JDK version

2014-06-23 Thread Bradford Wetmore
Except for these two classes, none of the JCE APIs ever contained @since until the JCE was put into JDK 1.4 back in 2002. The unbundled JCE hasn't been shipped in probably almost a decade. None of the unbundled JSSE/JGSS should have them either. Carrying around this old information is just c