RFR 8014870: Faster KDC availability check in Kerberos

2014-06-24 Thread Wang Weijun
Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8014870/webrev.00/ In Kerberos, when trying to request for a ticket, we tried multiple KDC servers for multiple times. Before this fix, we connect to a server, wait for 30 seconds (the default kdc_timeout). If there

Re: RFR: 8015081

2014-06-24 Thread Xuelei Fan
1. Why make the following update? removeAll() is a method of AbstractSet. private static class SecureSet -extends AbstractSet -implements java.io.Serializable { +implements Set, java.io.Serializable { 2. Per Java coding conversions, please always use braces even for s

Re: RFR: 8015081

2014-06-24 Thread Jamil Nimeh
Hi Xuelei, thanks for the comments! #1: Removal of SecureSet from AbstractSet's hierarchy was a request made by Sean earlier this month. One of his concerns was to insulate SecureSet from changes/new methods added to AbstractSet, where the superclass method wouldn't work well with the impleme

Re: ThreadLocalRandom clinit troubles

2014-06-24 Thread Peter Levart
Hi Martin, On 06/22/2014 07:12 PM, Martin Buchholz wrote: We know that loading the networking machinery is problematic. On Linux we would be content to hard-code a read from /dev/urandom, which is safer and strictly more random than the existing network hardware determination, but y'all will re

Re: [9] request for review 8047353: Improve error message when a JAR with invalid signatures is loaded

2014-06-24 Thread Aaron Digulla
Am Donnerstag, 19. Juni 2014 23:49 CEST, Joe Darcy schrieb: > I'd prefer to see the CheckJarSigError.sh as a Java program. There original bug report contains a full self-contained test case in Java. Why was that split into several files? I'm also a bit uneasy about the "just show the file nam

Re: RFR: 8047721: @since should have JDK version

2014-06-24 Thread Paul Benedict
What's the rationale for removing the secondary version? Or I guess the question should really be: when are secondary versions useful? At least in the EE specs, the EE version plus the spec version are listed in many places like this. Cheers, Paul On Mon, Jun 23, 2014 at 3:50 PM, Henry Jen wro

Re: ThreadLocalRandom clinit troubles

2014-06-24 Thread Peter Levart
On 06/24/2014 06:01 PM, Martin Buchholz wrote: On Tue, Jun 24, 2014 at 7:03 AM, Peter Levart > wrote: I would rather use SecureRandom.generateSeed() instance method instead of SecureRandom.nextBytes(). Why? Because every SecureRandom instance has