Re: RFR 8048511: Uninitialised memory in jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c

2014-07-01 Thread Valerie Peng
Changes look fine. Thanks, Valerie On 6/30/2014 6:07 PM, Wang Weijun wrote: Hi Valerie Please review a fix at http://cr.openjdk.java.net/~weijun/8048511/webrev.00/ A static code analysis tool is not happy to see the minor variable not initialized (if none of the ifs in lines 652-658 ret

Re: A Bug in AccessControlContext.equals() and hashCode()?

2014-07-01 Thread Jeff Nisewanger
On 6/25/2014 9:02 PM, Xiaomin Ding wrote: On 6/16/2014 10:40 PM, David M. Lloyd wrote: On 06/16/2014 09:19 AM, Frank Ding wrote: Hi Jeff, Thanks for your reply. One further question is that you confirmed that two AccessControlContext objects considered equal via method equals() should return

RFR 8047765: Generate blacklist.certs in build

2014-07-01 Thread Wang Weijun
Hi All Please review the fix at http://cr.openjdk.java.net/~weijun/8047765/webrev.00/ where the generation of blacklisted.certs is moved from developer-manual to build-auto. I copied the mechanisms from GENDATA_HTML32DTD. One thing I am not sure about is that if I update the tool a little,

Re: RFR 8047765: Generate blacklist.certs in build

2014-07-01 Thread David Holmes
Hi Max, On 2/07/2014 1:46 PM, Wang Weijun wrote: Hi All Please review the fix at http://cr.openjdk.java.net/~weijun/8047765/webrev.00/ where the generation of blacklisted.certs is moved from developer-manual to build-auto. I copied the mechanisms from GENDATA_HTML32DTD. Seems like a re

Re: RFR 8047765: Generate blacklist.certs in build

2014-07-01 Thread Wang Weijun
On Jul 2, 2014, at 12:48, David Holmes wrote: > > 73 // Output sorted for eye pleasure. > > ?? "eye pleasure" Well, it's easy for a human to locate one from a sorted output. Or maybe it's because the old one is sorted and I don't want the new one looks ugly. --Max

RFR 8042053: Broken links to jarsigner and keytool docs in java.security package summary

2014-07-01 Thread Wang Weijun
Please review the fix at http://cr.openjdk.java.net/~weijun/8042053/webrev.00/ The Unix-style doc for security tools are in unix/ since JDK 8. Thanks Max