Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-08-06 Thread Erik Joelsson
On 2014-08-05 23:24, Sean Mullan wrote: On 07/28/2014 09:53 AM, Wang Weijun wrote: Yes, you are right. Webrev updated at http://cr.openjdk.java.net/~weijun/6997010/webrev.02. GendataJavaSecurity.gmk and MakeJavaSecurity.java updated. There's an unnecessary indent at line 1 of GendataJavaSe

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-08-06 Thread Weijun Wang
On 8/6/2014 17:04, Erik Joelsson wrote: Speaking of indentation, please also change the ifdef bodies to 2 spaces. Sure. Whenever I edit a Makefile, I dare not use spaces and always use TABs. Obviously an ifdef does not need it. Thanks Max

Re: RFR 6997010: Consolidate java.security files into one file with modifications

2014-08-06 Thread Erik Joelsson
On 2014-08-06 11:14, Weijun Wang wrote: On 8/6/2014 17:04, Erik Joelsson wrote: Speaking of indentation, please also change the ifdef bodies to 2 spaces. Sure. Whenever I edit a Makefile, I dare not use spaces and always use TABs. Obviously an ifdef does not need it. The tab character unfo

Re: On 8038089: TLS optional support for Kerberos cipher suites needs to be re-examine

2014-08-06 Thread Xuelei Fan
Weijun, Where the krb5 impl will be packaged into in the future? Still the SunProvider but in a new jar file? I was wondering whether we can use the provider service approach that we used to define other security components implementations. I'm not quite confident with the security of the use o

[9] RFR: 8054380: X.509 cert extension SubjectAltName should allow digits as first character of dNSName

2014-08-06 Thread Jason Uh
Please review this fix, which allows the first character of a DNSName in a SubjectAltName to be either a letter or a digit. http://cr.openjdk.java.net/~juh/8054380/webrev.01/ This change is to stay compliant with RFC 1123: RFC 1123, Section 2.1: One aspect of host name syntax is hereby chang

Re: RFR J8050281: New permission tests for JEP 140

2014-08-06 Thread Amanda Jiang
Updated the original codes for better handling interrupted exception. webrev: http://cr.openjdk.java.net/~tyan/amandaj/JDK-8031661/webrev.01/ Thanks, Amanda On 7/30/14 4:50 PM, Amanda Jiang wrote: Hi All, Could you please review following 2 new regression tests to be added for JEP140 (Limied

Re: RFR J8050281: New permission tests for JEP 140

2014-08-06 Thread Amanda Jiang
Sorry, wrong webrev link, it should be: http://cr.openjdk.java.net/~tyan/amandaj/8050281/webrev.01/ Thanks, Amanda On 8/6/14 3:24 PM, Amanda Jiang wrote: Updated the original codes for better handling interrupted exception. webrev: http://cr.openjdk.java.net/~tyan/amandaj/JDK-8031661/webrev.0

Re: On 8038089: TLS optional support for Kerberos cipher suites needs to be re-examine

2014-08-06 Thread Weijun Wang
On 8/6/2014 20:55, Xuelei Fan wrote: Weijun, Where the krb5 impl will be packaged into in the future? In the java.jgss module. Still the SunProvider but in a new jar file? I was wondering whether we can use the provider service approach that we used to define other security components im