Re: Replace concat String to append in StringBuilder parameters

Hi Otávio, I think you should fix the indentation in a lot of classes. You use the tab-character for the indentation. As far as I know we should use the space character for the indentation in the JDK sources (Oracle devs feel free to correct me if I'm wrong. And it would be really nice if the styl

Re: Replace concat String to append in StringBuilder parameters

No TAB, no \r, and no trailing space are hard requirements enforced by jcheck. Otherwise it's only styles, including 4-space-indentation. "{" at the end of a line, 8-space wrap indentation... --Max (an Oracle dev) On Aug 12, 2014, at 15:48, Andrej Golovnin wrote: > As far as I know we should

Re: The future of Serialization

Interesting, language features for modules, won't necessarily involve ClassLoader's (my assumptions were based on existing systems) although you'd expect modules to have their own ProtectionDomain. An alternative to isolates, is separate processes with jvm class sharing enabled. I'll keep an e

Re: [8u40] Request for approval: 8035974 Refactor DigestBase.engineUpdate() method for better code generation by JIT compiler

Thank you! Vladimir On 8/12/14 2:02 AM, dalibor topic wrote: Approved. cheers, dalibor topic On 11.08.2014 21:35, Vladimir Kozlov wrote: Requesting approval for the backport of JDK-8035974. The change was pushed to jdk 9 in May and it is applied cleanly to jdk8u sources: Main RFE: https://

Review Request for 7026255 : Methods of Subject that throw SecurityException do not specify what permissions are required

This is a clarification in the javax.security.auth.Subject javadocs to indicate what permissions are required for methods that throw SecurityException: http://cr.openjdk.java.net/~mullan/webrevs/7026255/webrev.00/ I also took the opportunity to fix a couple of other minor issues: added @Overr

Re: Updated review request for CR 8048362 Test doPrivileged with accomplice

Hello , The latest webrev is available at http://cr.openjdk.java.net/~rhalade/8048362/webrev.03/ The changes include review comments from Vinnie . Thanks, Raghu On 8/8/2014 7:21 PM, Vincent Ryan wrote: Code looks fine. I noticed a f

Re: [8u40] Request for approval: 8035974 Refactor DigestBase.engineUpdate() method for better code generation by JIT compiler

Approved. cheers, dalibor topic On 11.08.2014 21:35, Vladimir Kozlov wrote: Requesting approval for the backport of JDK-8035974. The change was pushed to jdk 9 in May and it is applied cleanly to jdk8u sources: Main RFE: https://bugs.openjdk.java.net/browse/JDK-8035974 Changeset: http://hg.op

Re: Review Request for 7026255 : Methods of Subject that throw SecurityException do not specify what permissions are required

In the new file: 653-677, 719-721: It would be nice to mention "if a security manager is installed," ... 656 * is thrown if the caller does not have the proper permissions. Do we want to point out the actual modify permissions? 721 * SecurityException will be thrown. --- Do